Feature: Use recommended SF symbols #41
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of bundling images it is recommended to use the equivalent SF symbols.
Some images were not appropriate for the case they were used in, so I replaced them with the appropriate alternative.
I also fixed a problem with the Symbols being cut as well as improperly scaled in some cases.
SF Symbols is available from macOS 11 onwards, so I changed the build target from 10.15 to 11, updated the project settings to the recommended settings and replaced a deprecated function call to NSWorkspace. Due to the optional nature of the presence of Xcode on a users host while Xcode is required to run I implemented a runtime check warning the user if Xcode is not found.
Hint: This is based on #40 - can be merged independently though