Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX-#6967: Remove read_pickle_distributed/to_pickle_distributed functions as deprecated #7258

Merged
merged 1 commit into from
May 13, 2024

Conversation

anmyachev
Copy link
Collaborator

@anmyachev anmyachev commented May 13, 2024

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves Remove read_pickle_distributed/to_pickle_distributed #6967
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

…ributed functions as deprecated

Signed-off-by: Anatoly Myachev <[email protected]>
@anmyachev anmyachev marked this pull request as ready for review May 13, 2024 10:08
@YarShev
Copy link
Collaborator

YarShev commented May 13, 2024

Are you aware of the failures in CI?

@anmyachev
Copy link
Collaborator Author

Are you aware of the failures in CI?

Lack of stability in the order of values after the merge function. Restarting helped, but explicit sorting may be required in the future.

@YarShev YarShev merged commit 9992b12 into modin-project:main May 13, 2024
38 checks passed
@anmyachev anmyachev deleted the issue6967 branch May 13, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove read_pickle_distributed/to_pickle_distributed
2 participants