Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support LLM augmentation ops and support vllm #338

Merged
merged 22 commits into from
Aug 29, 2024
Merged

support LLM augmentation ops and support vllm #338

merged 22 commits into from
Aug 29, 2024

Conversation

Cathy0908
Copy link
Collaborator

@Cathy0908 Cathy0908 commented Jul 4, 2024 •
edited
Loading

Add new operators for llm data augmentation:

  • GenerateInstructionMapper
  • OptimizeInstructionMapper
  • ExtractQAMapper

And support vllm infer for these ops.

@drcege drcege added the dj:op issues/PRs about some specific OPs label Jul 8, 2024
@Cathy0908 Cathy0908 changed the title support GenerateInstructionMapper [WIP] support GenerateInstructionMapper, OptimizeInstructionMapper and support vllm Jul 16, 2024
@Cathy0908 Cathy0908 changed the title [WIP] support GenerateInstructionMapper, OptimizeInstructionMapper and support vllm [WIP] support LLM augmentation ops and support vllm Jul 25, 2024
@Cathy0908 Cathy0908 changed the title [WIP] support LLM augmentation ops and support vllm support LLM augmentation ops and support vllm Jul 25, 2024
@yxdyc yxdyc requested a review from pan-x-c July 26, 2024 08:55
yxdyc
yxdyc reviewed Jul 31, 2024
View reviewed changes
Copy link
Collaborator

@yxdyc yxdyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice features. Plz see the inline comments.

configs/config_all.yaml Outdated Show resolved Hide resolved
data_juicer/config/config.py Outdated Show resolved Hide resolved
data_juicer/ops/mapper/extract_qa_mapper.py Outdated Show resolved Hide resolved
data_juicer/ops/mapper/generate_instruction_mapper.py Show resolved Hide resolved
data_juicer/ops/mapper/extract_qa_mapper.py Show resolved Hide resolved
garyzhang99
garyzhang99 approved these changes Aug 29, 2024
View reviewed changes
Copy link
Collaborator

@garyzhang99 garyzhang99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HYLcool HYLcool merged commit 22834ba into modelscope:main Aug 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HYLcool HYLcool HYLcool left review comments

@yxdyc yxdyc yxdyc left review comments

@garyzhang99 garyzhang99 garyzhang99 approved these changes

@drcege drcege Awaiting requested review from drcege

@zhijianma zhijianma Awaiting requested review from zhijianma

@pan-x-c pan-x-c Awaiting requested review from pan-x-c

Assignees
No one assigned
Labels
dj:op issues/PRs about some specific OPs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Cathy0908 @HYLcool @garyzhang99 @yxdyc @drcege