Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds wandb to CI, fixes seed #61

Merged
merged 1 commit into from
May 23, 2024
Merged

adds wandb to CI, fixes seed #61

merged 1 commit into from
May 23, 2024

Conversation

charlesfrye
Copy link
Contributor

modal-pr-review-automation[bot]
modal-pr-review-automation bot approved these changes May 23, 2024
View reviewed changes
Copy link

@modal-pr-review-automation modal-pr-review-automation bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved 👍. This diff qualified for automatic approval and doesn't need follow up review.

@charlesfrye
Copy link
Contributor Author

[SQL] is sometimes getting left off -- should separate out a validation set to reduce randomness so i don't have to go fishing for a seed that gives good behavior.

@charlesfrye charlesfrye merged commit 5eb7c4b into main May 23, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@modal-pr-review-automation modal-pr-review-automation[bot] modal-pr-review-automation approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@charlesfrye