Refactoring: Consuming log-symbols alternate to code for win32 in reporters/base. #4389
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
I used the
log-symbols
instead of the code for win32.Alternate Designs
No alternate designs
Benefits
Mocha already uses
log-symbols
, so we can remove duplicated code and maintain consistency.Possible Drawbacks
I also deleted the
dot
case, But I don't know if the size difference between dot for win32(.
) and dot for the others(․
) is a problem.So I think this might be a problem.
Applicable issues
[WSL] Test report corruption #4353
The above issue is not directly related to the PR.
But I think you may want to use alphabets rather than
log-symbols
to resolve the issue.like this
Please leave a good comment or question at any time :)