Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: simplify test, and exclude macOS (darwin) #11

Closed
wants to merge 1 commit into from

Conversation

thaJeztah
Copy link
Member

Excluding darwin, as this package doesn't support it, but a developer may try running the tests on a Mac.

Excluding darwin, as this package doesn't support it, but
a developer may try running the tests on a Mac.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah
Copy link
Member Author

/cc @kolyshkin

@kolyshkin
Copy link
Collaborator

@thaJeztah have you checked if CI failures are related?

I'm afraid they are. This is a thing with two dependent packages from the same repo. If you want to test them together, you need to add replace github.com/moby/sys/mountinfo ../mountinfo in mount's go.mod for the test. I think it makes more sense to test packages separately, but I am open to discussion.

I suggest drop the makefile changes, but keep the package changes.

Or, add the above replace in the test.

@thaJeztah
Copy link
Member Author

Oh, thanks for the ping; yes, I think the failure is related, I realised this doesn't work after opening (but didn't dig deep yet).

Let me have a look at splitting that change

@thaJeztah
Copy link
Member Author

@kolyshkin opened #13

closing this one

@thaJeztah thaJeztah closed this May 13, 2020
@thaJeztah thaJeztah deleted the simplify_test branch May 13, 2020 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants