Makefile: rm .SHELLFLAGS, add set -e #105
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently GHA CI Mac OS X environment uses old GNU Make (v3.81) which
does not yet support
.SHELLFLAGS
(added by commit 8589e2e).Since we call a few commands (under
for
) from the make target,intermediate failures are ignored unless
-e
shell option is set (orexplicit
&&
is used, which is not possible to do infor
).Example:
will succeed unless
set -e
is set, because the last command executed istrue
and its exit code is0
.To fix, use explicit
set -e
where we execute more than a single command.Also, replace
&&
with;
for multiple commands. Technically this is notrequired for the fix, but since having
set -e
results in implicit&&
everywhere,there is no need to have
&&
explicitly. In other words, this change ismore like a reminder that we do not have to use
&&
here.Fixes: 8589e2e
Fixes: #99