-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failed to run TestGetMounts in chroot #17
Comments
kolyshkin
added a commit
to kolyshkin/sys
that referenced
this issue
Jun 24, 2020
Apparently, Ubuntu build system is some sort of a chroot which does not have / mount in its /proc/self/mountinfo. This leads to test failure described in moby#17. The fix is not to require a specific mount (even '/' that must exist but apparently does not in some setups). Instead, let's require at least 2 mounts, doesn't matter which ones. For reference, his test case was added by moby/moby#4812 Signed-off-by: Kir Kolyshkin <[email protected]>
This test was added by PR |
kolyshkin
added a commit
to kolyshkin/sys
that referenced
this issue
Jun 24, 2020
Apparently, Ubuntu build system is some sort of a chroot which does not have / mount in its /proc/self/mountinfo. This leads to test failure described in moby#17. The fix is not to require a specific mount (even '/' that must exist but apparently does not in some setups). Instead, let's require at least 2 mounts, doesn't matter which ones. For reference, his test case was added by moby/moby#4812 Signed-off-by: Kir Kolyshkin <[email protected]>
The Linux kernel's show_mountinfo() has a check that the mount is accessible, and it is not shown if not. Looks like this is why the mount for / is not shown in the Ubuntu case -- they have some weird setup. Nevertheless, a proposed fix is #18. |
kolyshkin
pushed a commit
to kolyshkin/sys
that referenced
this issue
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Background:
I packaged this library in Debian[1], and Ubuntu synced it to its archive[2]. But I found in Ubuntu it failed to build. After inspecting the log[3], I think the reason is
TestGetMounts
.Ubuntu builds this library with chroot. So I test it in a chroot and add some logs.
Since this test reads
/proc/self/mountinfo
, change the test from/
to/proc
is much better.[1] https://tracker.debian.org/pkg/golang-github-moby-sys
[2] https://launchpad.net/ubuntu/+source/golang-github-moby-sys
[3] https://launchpadlibrarian.net/482039299/buildlog_ubuntu-groovy-amd64.golang-github-moby-sys_0.0~git20200518.0783079-1_BUILDING.txt.gz
The text was updated successfully, but these errors were encountered: