Error out if client API version is too old #13997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @tiborvass @cpuguy83 |
|
janky :( |
|
Arrrggg |
|
LGTM once you bribe the janky gods |
Signed-off-by: Antonio Murdaca <[email protected]>
|
no way janky's going to pass today... |
|
Added to 1.7.1 since that's what we discussed on IRC yesterday. |
why? this is not a bug, per-se, is it? |
|
Because it kind of is a bug, since we're either receiving and not handling data from a client, or sending unexpected data to a client. |
|
LGTM |
LK4D4
added a commit
that referenced
this pull request
Jun 20, 2015
Error out if client API version is too old
|
Definitely +1 from me on adding this to 1.7.1 -- IMO it's definitely a bug
that remote API clients using older API versions are suddenly and without
warning getting data as if their API version is "latest" instead of an
error message informing them this is a problem.
|
|
Cherry picked. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While at it, I've modified api consts against lint errors (will split it out if it's not ok)
Signed-off-by: Antonio Murdaca [email protected]