Add allowFieldArgs #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fields with arguments are ignored by default by the generator. With --allowFieldArgs one can have approriate definitions generated for such fields as well.
| @@ -294,7 +295,7 @@ ${generateFragments(name, primitiveFields, nonPrimitiveFields)} | |||
| let modelProperties = "" | |||
| if (type.fields) { | |||
| modelProperties = type.fields | |||
| .filter(field => field.args.length === 0) | |||
There was a problem hiding this comment.
I'm curious why this line was here in the first place (@mweststrate) but if things work fine without it I'm all for just removing it entirely vs. adding an allowFieldArgs option.
There was a problem hiding this comment.
hmm yeah, I thought maybe originally it was meant as field.args.length !== 0 but does not make sense either down the line. I agree @chrisdrackett just drop only that line (would as well reduce all the unrelated formatting changes) 
|
closing due to duplicate #90 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fields with arguments are ignored by default by the generator. With
--allowFieldArgs one can have approriate definitions generated for
such fields as well.
Fixes #46