Add --dynamicArgs option to generate operation arguments dynamically #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally for any graphql operation with arguments every formal and actual argument has been generated into the corresponding function in RootStore.base.ts. Using --dynamicArgs=true or setting in mst-gql.config.js dynamicArgs:true will cause generation of operation functions, which will create graphql operations, which only define those arguments, which have a matching variable set in "variables". This dynamic argument generation solves issues with Hasura mutations as well.
|
@beepsoft could you sort out this merge error? |
|
Yes, I was expecting this, will fix soon. |
# Conflicts: # generator/generate.js
|
@jesse-savary does it merge now OK? |
|
Yep @beepsoft |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #362 (Should be merged after #361)
Originally for any graphql operation with arguments every formal and actual
argument has been generated into the corresponding function in
RootStore.base.ts.
Using --dynamicArgs or setting in mst-gql.config.js dynamicArgs:true
will cause generation of operation functions, which will create graphql
operations, which only define those arguments, which have a matching
variable set in "variables". This dynamic argument generation solves issues
with Hasura mutations as well.