Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generating typescript input types #36

Merged
merged 4 commits into from
Jun 21, 2019
Merged

generating typescript input types #36

merged 4 commits into from
Jun 21, 2019

Conversation

elie222
Copy link
Collaborator

@elie222 elie222 commented Jun 17, 2019

Addresses:
#28

@elie222 elie222 requested a review from mweststrate June 17, 2019 17:53
@elie222 elie222 changed the title added basic input type support with any generating typescript input types Jun 17, 2019
mweststrate
mweststrate approved these changes Jun 18, 2019
View reviewed changes
Copy link
Member

@mweststrate mweststrate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@antondomratchev
Copy link

@elie222 Would love to see this PR merged, it looks like @mweststrate 👌 it

@elie222 elie222 merged commit dbf59af into mobxjs:master Jun 21, 2019
@elie222 elie222 deleted the input-type-any branch June 21, 2019 06:44
This was referenced Jun 23, 2019
Closed
Merged
@mweststrate mweststrate mentioned this pull request Aug 2, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweststrate mweststrate mweststrate approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elie222 @antondomratchev @mweststrate