MobX 6 Support #294
Merged
MobX 6 Support #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BradenM Thanks for this, I've tested this and it looks good! Great if someone else could test this as well @chrisdrackett @special-character |
|
It works for me as well. Note that with the latest mobx (6.1.4) you get this error mobxjs/mobx-state-tree#1653, which will be hopefully fixed soon. So for now I just use "6.0.4" as you did, and with that it works all right. |
|
@beepsoft this been fixed with Version 5.0.1 |
|
Hi, what about the new version of the package? there seems to be a lot of changes since version 0.13.0 |
jesse-savary
pushed a commit
that referenced
this pull request
Mar 13, 2021
* feat(deps): upgrade babel/mobx deps to mobxv6 * feat(query): migrate to mobx v6 * Put babelrc back so tests pass * Remove unneeded transform in babelrc so rollup can build successfully https://www.npmjs.com/package/@rollup/plugin-babel#modules * fix(ts): type error TS7006 in query Co-authored-by: Brandon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for MobX 6
Upgraded appropriate packages and ran the mobx-undecorate codemod to make the few required changes.
Caused one minor type issue that was easily resolved.
Currently working fine in one of my soon-to-be production react-native applications.
Also 🍒 picked @special-character 's
babelrcchanges from #288 to fix the test suite.Closes #284