Adds onError handler to subscription #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -112,17 +112,22 @@ export const MSTGQLStore = types | |||
| function subscribe<T = any>( | |||
| query: string | DocumentNode, | |||
| variables?: any, | |||
| onData?: (item: T) => void | |||
| onData?: (item: T) => void, | |||
| onError: (error: Error) => void = error => { | |||
There was a problem hiding this comment.
should we make onError optional? Keep existing behavior if you don't pass it in, but if you do give access to the error?
There was a problem hiding this comment.
Thanks for the quick reply. So it is optional because I am supplying a default onError here and the default onError is just a simple function that throws the passed error. If you prefer I can make it optional and use a check inline and throw if the function isnt defined.
There was a problem hiding this comment.
yup, you are correct, I totally glanced over this line!
chrisdrackett
approved these changes
Jul 30, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are having issues with handling errors thrown inside a subscription. I looked around and couldn't find any suggested way of handling this. I think this simple fix would get us what we need. If there is a better way of handling these types of errors please let me know.