Allow LIST to be optional in TS #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @zenflow - I saw you were active on some recent code reviews. Can you take a look at this when you get a chance? This is a pretty fundamental bug I feel since an optional list is a pretty common use-case. Thanks in advance |
|
@Aryk Sure, I'd be happy to! But I won't be really able to for about a week. Feel free to ping me then, if I don't get around to it beforehand. |
|
@zenflow can this be merged? |
|
Hey @zenflow any updates on this one? |
chrisdrackett
approved these changes
Apr 9, 2020
|
No problem, thanks for merging. Excited to use the new release. Just curious, when will there be a new version on npm? |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #165