Apply 'curly' ESLint rule + run Prettier on changed files #3294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
kubk
commented
Feb 12, 2022
| @@ -15,6 +15,7 @@ module.exports = { | |||
| rules: { | |||
| "no-fallthrough": "off", | |||
| "no-constant-condition": "off", | |||
| curly: "error", | |||
There was a problem hiding this comment.
It looks inconsistent, but Prettier decided to remove quotes here. That's because it tries to avoid them if possible
kubk
force-pushed
the
apply-curly-eslint-rule
branch
from
908c54a
to
a030d10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related discussion: #3287 (comment)
This PR applies ESLint rule "curly" on the whole code base: https://eslint.org/docs/rules/curly
What ESLint documentation says about this rule: "it is considered by many to be best practice to never omit curly braces around blocks, even when they are optional, because it can lead to bugs and reduces code clarity"
The commit was generated automatically using
yarn lint --fix && yarn prettier. Prettier changes were applied only for changed files. Just in case I checked that this change doesn't affect bundle at all. Here are the results of running commandyarn lerna run test:sizebefore and after applying changes:It's a screenshot from https://www.diffchecker.com/diff