Fix: RangeError in ObservableArray.replace for large arrays #3189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f430fb0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Good call, thank you! Can you add a changeset? |
urugator
reviewed
Nov 22, 2021
|
Looking great! Thanks for the tests and comments, and digging into this problem in the first place! |
mweststrate
approved these changes
Nov 24, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! I noticed an error in my application when working with long lists, traced it back down to here.
Here's a minimal repro (included in the new test case) https://codesandbox.io/s/inspiring-matsumoto-kbjzc?file=/src/index.ts
It only seems to happen when both arrays are larger than
MAX_SPLICE_SIZEand the original array is larger than its replacementCheers!
Code change checklist
/docs. For new functionality, at leastAPI.mdshould be updatedyarn mobx test:performance)