ESlint plugin

[urugator]

Experimental and work in progress. Not completely commited to finish this. Not sure if there is an interest and enough use cases.

Looking for feedback, ideas, help (mainly with chore and setting up the project correctly)

exhaustive-make-observable

missing-make-observable

unconditional-make-observable

[changeset-bot]

⚠️ No Changeset found

Latest commit: 3fda09c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[kubk]

Hi @urugator I have a question regarding the first rule. Does it complain about all the class properties? I thought that the whole point of makeObservable is to have an option to intentionally skip some properties, e.g

class Store {
  o = 1;
  localStorageKey = 'some-key';
  
  constructor() {
    makeObservable(this, {
      o: observable,
      // Avoid marking localStorageKey because it's just a key for local storage
    })
  }
}

[urugator]

@kubk The rule forces you to be explicit about this: { localStorageKey: false }.
Just to clarify, the auto-fix adds { prop: true } to annotations.

[mweststrate]

This looks really awesome and super helpful! Looks to me pretty good to publish as-is, and we can iterate over it further with the community if needed.

[iChenLei]

I have a small issue, eslint-plugin-mobx has been registered on npmjs.org.

https://www.npmjs.com/package/eslint-plugin-mobx

Get in touch with the eslint-plugin-mobx's owner @chrisands to transfer package or release a new package(e.g @mobx/eslint-plugin) ?

cc @mweststrate @urugator , this is a small but important thing.

[iChenLei]

@urugator I am sorry for click merge main branch, did it cause problems for your development?

[urugator]

I will merge this as is and create a new PR with changeset.