Revert mobx 4 symbol support #1988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b7be184.
|
cc: @loklaan |
|
I thought this might have to happen after looking into it yesterday. Sorry I didn't give the mobx 4 branch enough thought while creating the initial PR for mobx 5. |
|
Merged and released as 4.11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I backported symbol support from MobX 5 to MobX 4, without thinking it really through. Although symbols could potentially be used in practice, this probably misses the point that mobx 4 is used in more backward compatible modi, and didn't require polyfills as of yet.
This PR reverts symbol support. A downside of this PR is that this increases the semantical difference between mobx 4 and 5
Fixes #1986, #1987