Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #529 #572

Merged
merged 2 commits into from
Oct 27, 2020
Merged

Fixes #529 #572

merged 2 commits into from
Oct 27, 2020

Conversation

pr-1
Copy link
Contributor

@pr-1 pr-1 commented Oct 1, 2020

Tasks Done -

  • Removed unused observable currentDescription from TodoList.
  • Removed onChange callback from TextField in AddTodo Widget.
  • Changed TextInputAction to TextInputAction.done
  • Updated tests accordingly. All test cases passed.

@codecov
Copy link

codecov bot commented Oct 1, 2020

Codecov Report

Merging #572 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #572   +/-   ##
=======================================
  Coverage   83.88%   83.88%           
=======================================
  Files          52       52           
  Lines        1800     1800           
=======================================
  Hits         1510     1510           
  Misses        290      290           
Flag Coverage Δ
#flutter_mobx 100.00% <ø> (ø)
#mobx 83.26% <ø> (ø)
#mobx_codegen 30.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ed4602...c511828. Read the comment docs.

@pr-1
Copy link
Contributor Author

pr-1 commented Oct 1, 2020

@pavanpodila Can you please review this. I don't know much about Codecov. If you can tell me is something wrong with my code ? Because in the Github Actions tab it says all checks have successfully passed.

Copy link
Collaborator

@MaikuB MaikuB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@pavanpodila I think there's an issue with duplicate codecov checks. There's one that says it's failed for flutter_mobx but then one that passes for flutter_mobx. It's at 100% code coverage as well. Not across how that is setup and may need looking into but I think we should be able to ignore it to merge this in.

@pavanpodila pavanpodila merged commit 25256bf into mobxjs:master Oct 27, 2020
@pavanpodila
Copy link
Member

@all-contributors add @pr-1 for example, code

@allcontributors
Copy link
Contributor

@pavanpodila

I've put up a pull request to add @pr-1! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants