Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install using api not working and other fixes #72

Merged
merged 5 commits into from
Jun 8, 2020
Merged

Conversation

dhoer
Copy link

@dhoer dhoer commented Jun 8, 2020

Fixed the following issues:

  • The examples on the readme to install matlab2tikz for tag, commit, and branch don't work. The api download is only for tags. I added a fix for this and as well as tests.
  • Readme was missing info about --approve flag.
  • Example downloading from fileexchange is not working because download link points to github. Replaced example with covidx package example that does have download link to fileexchange. Added test for fileexchange.
  • Added tests for search, freeze, install via git clone, and infile
  • export_fig uses git url in requirements-example.txt, since fileexchange doesn't work

@dhoer
Copy link
Author

dhoer commented Jun 8, 2020

BTW, thanks for the quick turn around on the --approve flag.

@mobeets
Copy link
Owner

mobeets commented Jun 8, 2020

Great!

@mobeets mobeets closed this Jun 8, 2020
@mobeets mobeets reopened this Jun 8, 2020
@mobeets mobeets merged commit cd2bf71 into mobeets:master Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants