Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add static typechecker to pre-commits and tests #44

Open
4 tasks
mmschlk opened this issue Feb 13, 2024 · 1 comment
Open
4 tasks

Add static typechecker to pre-commits and tests #44

mmschlk opened this issue Feb 13, 2024 · 1 comment
Labels
help wanted Extra attention is needed maintenance

Comments

@mmschlk
Copy link
Owner

mmschlk commented Feb 13, 2024

We should add mypy static type checking. This will however need some changes in what typehints we currently are using. Especially there will be problems/changes with current np.ndarry[int] kind of hints.

@mmschlk mmschlk added enhancement New feature or request help wanted Extra attention is needed labels Feb 13, 2024
@mmschlk mmschlk added this to the Initial Version of SHAPIQ milestone Feb 13, 2024
@mmschlk
Copy link
Owner Author

mmschlk commented Mar 22, 2024

While this is an important issue it may be out of scope for the initial version of SHAPIQ

@mmschlk mmschlk removed this from the Initial Version of SHAPIQ milestone Mar 22, 2024
@hbaniecki hbaniecki added maintenance and removed enhancement New feature or request labels Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed maintenance
Projects
Status: 📋 Backlog
Development

No branches or pull requests

2 participants