add greek language #958
Merged
add greek language #958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @Stelios3g |
NicolasT
referenced
this pull request
in NicolasT/nicolast.github.io
May 30, 2017
* tag '4.4.1': (33 commits) Release 💎 4.4.1 Transition “hamburger” navicon on click to “X” navicon by adding `.close` to button - Close 969 Add link to comment New comment. (#968) New comment. (#967) Update CHANGELOG and history Sync `/docs` with root changes Update ui-text.yml (#958) fix(includes/video): use https always (#945) Update history Release 💎 4.4.0 Move SCSS partials to `/_sass/minimal-mistakes` for easier CSS customization Fixed link errors in docs (#946) Add closing `}` Fix `.masthead` and `.page__footer` overlapping full screen video elements. - Close #933 Update CHANGELOG and history Add ProTip about installing unreleased version on `master` Replace modified with last_modified_at (#930) Update CHANGELOG and history Add Lithuanian language/locale (#924) ... Conflicts: .github/CONTRIBUTING.md .github/ISSUE_TEMPLATE.md CHANGELOG.md README.md docs/_data/navigation.yml docs/_data/ui-text.yml docs/_docs/01-quick-start-guide.md docs/_docs/02-structure.md docs/_docs/03-installation.md docs/_docs/04-upgrading.md docs/_docs/05-configuration.md docs/_docs/06-overriding-theme-defaults.md docs/_docs/07-navigation.md docs/_docs/08-ui-text.md docs/_docs/09-authors.md docs/_docs/10-layouts.md docs/_docs/11-posts.md docs/_docs/12-pages.md docs/_docs/13-collections.md docs/_docs/14-helpers.md docs/_docs/15-utility-classes.md docs/_docs/16-stylesheets.md docs/_docs/17-javascript.md docs/_docs/18-history.md docs/_docs/19-contributing.md docs/_docs/20-docs-2-2.md docs/_docs/21-license.md docs/_includes/video docs/_layouts/default.html docs/_layouts/single.html docs/_layouts/splash.html docs/_pages/about.md docs/_pages/home.md docs/_pages/terms.md docs/_posts/2010-01-07-post-modified.md docs/_posts/2012-03-15-layout-header-overlay-image.md docs/_posts/2013-08-16-markup-syntax-highlighting.md docs/_posts/2016-09-21-gemified-theme-alpha.md docs/_posts/2016-10-06-gemified-theme-beta.md docs/_sass/minimal-mistakes/_animations.scss docs/_sass/minimal-mistakes/_archive.scss docs/_sass/minimal-mistakes/_base.scss docs/_sass/minimal-mistakes/_buttons.scss docs/_sass/minimal-mistakes/_footer.scss docs/_sass/minimal-mistakes/_forms.scss docs/_sass/minimal-mistakes/_masthead.scss docs/_sass/minimal-mistakes/_mixins.scss docs/_sass/minimal-mistakes/_navigation.scss docs/_sass/minimal-mistakes/_notices.scss docs/_sass/minimal-mistakes/_page.scss docs/_sass/minimal-mistakes/_reset.scss docs/_sass/minimal-mistakes/_sidebar.scss docs/_sass/minimal-mistakes/_syntax.scss docs/_sass/minimal-mistakes/_tables.scss docs/_sass/minimal-mistakes/_utilities.scss docs/_sass/minimal-mistakes/_variables.scss docs/_sass/minimal-mistakes/vendor/breakpoint/_breakpoint.scss docs/_sass/minimal-mistakes/vendor/breakpoint/_context.scss docs/_sass/minimal-mistakes/vendor/breakpoint/_helpers.scss docs/_sass/minimal-mistakes/vendor/breakpoint/_legacy-settings.scss docs/_sass/minimal-mistakes/vendor/breakpoint/_no-query.scss docs/_sass/minimal-mistakes/vendor/breakpoint/_parsers.scss docs/_sass/minimal-mistakes/vendor/breakpoint/_respond-to.scss docs/_sass/minimal-mistakes/vendor/breakpoint/_settings.scss docs/_sass/minimal-mistakes/vendor/breakpoint/parsers/_double.scss docs/_sass/minimal-mistakes/vendor/breakpoint/parsers/_query.scss docs/_sass/minimal-mistakes/vendor/breakpoint/parsers/_resolution.scss docs/_sass/minimal-mistakes/vendor/breakpoint/parsers/_single.scss docs/_sass/minimal-mistakes/vendor/breakpoint/parsers/_triple.scss docs/_sass/minimal-mistakes/vendor/breakpoint/parsers/double/_default-pair.scss docs/_sass/minimal-mistakes/vendor/breakpoint/parsers/double/_default.scss docs/_sass/minimal-mistakes/vendor/breakpoint/parsers/double/_double-string.scss docs/_sass/minimal-mistakes/vendor/breakpoint/parsers/resolution/_resolution.scss docs/_sass/minimal-mistakes/vendor/breakpoint/parsers/single/_default.scss docs/_sass/minimal-mistakes/vendor/breakpoint/parsers/triple/_default.scss docs/_sass/minimal-mistakes/vendor/font-awesome/_animated.scss docs/_sass/minimal-mistakes/vendor/font-awesome/_bordered-pulled.scss docs/_sass/minimal-mistakes/vendor/font-awesome/_core.scss docs/_sass/minimal-mistakes/vendor/font-awesome/_fixed-width.scss docs/_sass/minimal-mistakes/vendor/font-awesome/_font-awesome.scss docs/_sass/minimal-mistakes/vendor/font-awesome/_icons.scss docs/_sass/minimal-mistakes/vendor/font-awesome/_larger.scss docs/_sass/minimal-mistakes/vendor/font-awesome/_list.scss docs/_sass/minimal-mistakes/vendor/font-awesome/_mixins.scss docs/_sass/minimal-mistakes/vendor/font-awesome/_path.scss docs/_sass/minimal-mistakes/vendor/font-awesome/_rotated-flipped.scss docs/_sass/minimal-mistakes/vendor/font-awesome/_screen-reader.scss docs/_sass/minimal-mistakes/vendor/font-awesome/_stacked.scss docs/_sass/minimal-mistakes/vendor/font-awesome/_variables.scss docs/_sass/minimal-mistakes/vendor/magnific-popup/_magnific-popup.scss docs/_sass/minimal-mistakes/vendor/magnific-popup/_settings.scss docs/_sass/minimal-mistakes/vendor/susy/_su.scss docs/_sass/minimal-mistakes/vendor/susy/_susy.scss docs/_sass/minimal-mistakes/vendor/susy/_susyone.scss docs/_sass/minimal-mistakes/vendor/susy/susy/_su.scss docs/_sass/minimal-mistakes/vendor/susy/susy/language/_susy.scss docs/_sass/minimal-mistakes/vendor/susy/susy/language/_susyone.scss docs/_sass/minimal-mistakes/vendor/susy/susy/language/susy/_background.scss docs/_sass/minimal-mistakes/vendor/susy/susy/language/susy/_bleed.scss docs/_sass/minimal-mistakes/vendor/susy/susy/language/susy/_box-sizing.scss docs/_sass/minimal-mistakes/vendor/susy/susy/language/susy/_breakpoint-plugin.scss docs/_sass/minimal-mistakes/vendor/susy/susy/language/susy/_container.scss docs/_sass/minimal-mistakes/vendor/susy/susy/language/susy/_context.scss docs/_sass/minimal-mistakes/vendor/susy/susy/language/susy/_gallery.scss docs/_sass/minimal-mistakes/vendor/susy/susy/language/susy/_grids.scss docs/_sass/minimal-mistakes/vendor/susy/susy/language/susy/_gutters.scss docs/_sass/minimal-mistakes/vendor/susy/susy/language/susy/_isolate.scss docs/_sass/minimal-mistakes/vendor/susy/susy/language/susy/_margins.scss docs/_sass/minimal-mistakes/vendor/susy/susy/language/susy/_padding.scss docs/_sass/minimal-mistakes/vendor/susy/susy/language/susy/_rows.scss docs/_sass/minimal-mistakes/vendor/susy/susy/language/susy/_settings.scss docs/_sass/minimal-mistakes/vendor/susy/susy/language/susy/_span.scss docs/_sass/minimal-mistakes/vendor/susy/susy/language/susy/_validation.scss docs/_sass/minimal-mistakes/vendor/susy/susy/language/susyone/_background.scss docs/_sass/minimal-mistakes/vendor/susy/susy/language/susyone/_functions.scss docs/_sass/minimal-mistakes/vendor/susy/susy/language/susyone/_grid.scss docs/_sass/minimal-mistakes/vendor/susy/susy/language/susyone/_isolation.scss docs/_sass/minimal-mistakes/vendor/susy/susy/language/susyone/_margin.scss docs/_sass/minimal-mistakes/vendor/susy/susy/language/susyone/_media.scss docs/_sass/minimal-mistakes/vendor/susy/susy/language/susyone/_padding.scss docs/_sass/minimal-mistakes/vendor/susy/susy/language/susyone/_settings.scss docs/_sass/minimal-mistakes/vendor/susy/susy/output/_float.scss docs/_sass/minimal-mistakes/vendor/susy/susy/output/_shared.scss docs/_sass/minimal-mistakes/vendor/susy/susy/output/_support.scss docs/_sass/minimal-mistakes/vendor/susy/susy/output/float/_container.scss docs/_sass/minimal-mistakes/vendor/susy/susy/output/float/_end.scss docs/_sass/minimal-mistakes/vendor/susy/susy/output/float/_isolate.scss docs/_sass/minimal-mistakes/vendor/susy/susy/output/float/_span.scss docs/_sass/minimal-mistakes/vendor/susy/susy/output/shared/_background.scss docs/_sass/minimal-mistakes/vendor/susy/susy/output/shared/_container.scss docs/_sass/minimal-mistakes/vendor/susy/susy/output/shared/_direction.scss docs/_sass/minimal-mistakes/vendor/susy/susy/output/shared/_inspect.scss docs/_sass/minimal-mistakes/vendor/susy/susy/output/shared/_margins.scss docs/_sass/minimal-mistakes/vendor/susy/susy/output/shared/_output.scss docs/_sass/minimal-mistakes/vendor/susy/susy/output/shared/_padding.scss docs/_sass/minimal-mistakes/vendor/susy/susy/output/support/_background.scss docs/_sass/minimal-mistakes/vendor/susy/susy/output/support/_box-sizing.scss docs/_sass/minimal-mistakes/vendor/susy/susy/output/support/_clearfix.scss docs/_sass/minimal-mistakes/vendor/susy/susy/output/support/_prefix.scss docs/_sass/minimal-mistakes/vendor/susy/susy/output/support/_rem.scss docs/_sass/minimal-mistakes/vendor/susy/susy/output/support/_support.scss docs/_sass/minimal-mistakes/vendor/susy/susy/su/_grid.scss docs/_sass/minimal-mistakes/vendor/susy/susy/su/_settings.scss docs/_sass/minimal-mistakes/vendor/susy/susy/su/_utilities.scss docs/_sass/minimal-mistakes/vendor/susy/susy/su/_validation.scss docs/assets/css/main.scss docs/assets/js/main.min.js docs/assets/js/plugins/jquery.greedy-navigation.js minimal-mistakes-jekyll.gemspec test/_pages/terms.md test/_posts/2010-01-07-post-modified.md test/_posts/2012-03-15-layout-header-overlay-image.md test/_posts/2013-08-16-markup-syntax-highlighting.md
wetty
added a commit
to wetty/wetty-web
that referenced
this pull request
Jun 5, 2017
* upstream/master: (80 commits) Remove extraneous `</a>` and `</li>` tags Removing extraneous a and li tags (mmistakes#1038) Fix "Greek" ~> "Swedish" typo Fix broken Kramdown TOC link Update CHANGELOG and history Add new brand variable: $bitbucket-color (mmistakes#1009) Add Swedish language Add Swedish language (mmistakes#996) Update CHANGELOG and history to reflect mmistakes#972 Update 08-ui-text.md (mmistakes#972) Toggle close button on `mouseleave` - Close mmistakes#975 Bump version to 4.4.1 Release 💎 4.4.1 Transition “hamburger” navicon on click to “X” navicon by adding `.close` to button - Close 969 Add link to comment New comment. (mmistakes#968) New comment. (mmistakes#967) Update CHANGELOG and history Sync `/docs` with root changes Update ui-text.yml (mmistakes#958) ... # Conflicts: # .github/CONTRIBUTING.md # .github/ISSUE_TEMPLATE.md # CHANGELOG.md # README.md # _sass/minimal-mistakes/_masthead.scss # _sass/minimal-mistakes/_syntax.scss # _sass/minimal-mistakes/_variables.scss # docs/_config.yml # docs/_data/navigation.yml # docs/_data/ui-text.yml # docs/_docs/01-quick-start-guide.md # docs/_docs/02-structure.md # docs/_docs/03-installation.md # docs/_docs/04-upgrading.md # docs/_docs/05-configuration.md # docs/_docs/06-overriding-theme-defaults.md # docs/_docs/07-navigation.md # docs/_docs/08-ui-text.md # docs/_docs/09-authors.md # docs/_docs/10-layouts.md # docs/_docs/11-posts.md # docs/_docs/12-pages.md # docs/_docs/13-collections.md # docs/_docs/14-helpers.md # docs/_docs/15-utility-classes.md # docs/_docs/16-stylesheets.md # docs/_docs/17-javascript.md # docs/_docs/18-history.md # docs/_docs/19-contributing.md # docs/_docs/20-docs-2-2.md # docs/_docs/21-license.md # docs/_includes/comments-providers/discourse.html # docs/_includes/comments.html # docs/_includes/head.html # docs/_includes/masthead.html # docs/_includes/paginator.html # docs/_includes/seo.html # docs/_includes/video # docs/_layouts/default.html # docs/_layouts/single.html # docs/_layouts/splash.html # docs/_pages/about.md # docs/_pages/home.md # docs/_pages/terms.md # docs/_posts/2010-01-07-post-modified.md # docs/_posts/2012-03-15-layout-header-overlay-image.md # docs/_posts/2013-08-16-markup-syntax-highlighting.md # docs/_posts/2016-09-21-gemified-theme-alpha.md # docs/_posts/2016-10-06-gemified-theme-beta.md # docs/_sass/minimal-mistakes/_animations.scss # docs/_sass/minimal-mistakes/_archive.scss # docs/_sass/minimal-mistakes/_base.scss # docs/_sass/minimal-mistakes/_buttons.scss # docs/_sass/minimal-mistakes/_footer.scss # docs/_sass/minimal-mistakes/_forms.scss # docs/_sass/minimal-mistakes/_mixins.scss # docs/_sass/minimal-mistakes/_navigation.scss # docs/_sass/minimal-mistakes/_notices.scss # docs/_sass/minimal-mistakes/_page.scss # docs/_sass/minimal-mistakes/_reset.scss # docs/_sass/minimal-mistakes/_sidebar.scss # docs/_sass/minimal-mistakes/_tables.scss # docs/_sass/minimal-mistakes/_utilities.scss # docs/_sass/minimal-mistakes/vendor/breakpoint/_breakpoint.scss # docs/_sass/minimal-mistakes/vendor/breakpoint/_context.scss # docs/_sass/minimal-mistakes/vendor/breakpoint/_helpers.scss # docs/_sass/minimal-mistakes/vendor/breakpoint/_legacy-settings.scss # docs/_sass/minimal-mistakes/vendor/breakpoint/_no-query.scss # docs/_sass/minimal-mistakes/vendor/breakpoint/_parsers.scss # docs/_sass/minimal-mistakes/vendor/breakpoint/_respond-to.scss # docs/_sass/minimal-mistakes/vendor/breakpoint/_settings.scss # docs/_sass/minimal-mistakes/vendor/breakpoint/parsers/_double.scss # docs/_sass/minimal-mistakes/vendor/breakpoint/parsers/_query.scss # docs/_sass/minimal-mistakes/vendor/breakpoint/parsers/_resolution.scss # docs/_sass/minimal-mistakes/vendor/breakpoint/parsers/_single.scss # docs/_sass/minimal-mistakes/vendor/breakpoint/parsers/_triple.scss # docs/_sass/minimal-mistakes/vendor/breakpoint/parsers/double/_default-pair.scss # docs/_sass/minimal-mistakes/vendor/breakpoint/parsers/double/_default.scss # docs/_sass/minimal-mistakes/vendor/breakpoint/parsers/double/_double-string.scss # docs/_sass/minimal-mistakes/vendor/breakpoint/parsers/resolution/_resolution.scss # docs/_sass/minimal-mistakes/vendor/breakpoint/parsers/single/_default.scss # docs/_sass/minimal-mistakes/vendor/breakpoint/parsers/triple/_default.scss # docs/_sass/minimal-mistakes/vendor/font-awesome/_animated.scss # docs/_sass/minimal-mistakes/vendor/font-awesome/_bordered-pulled.scss # docs/_sass/minimal-mistakes/vendor/font-awesome/_core.scss # docs/_sass/minimal-mistakes/vendor/font-awesome/_fixed-width.scss # docs/_sass/minimal-mistakes/vendor/font-awesome/_font-awesome.scss # docs/_sass/minimal-mistakes/vendor/font-awesome/_icons.scss # docs/_sass/minimal-mistakes/vendor/font-awesome/_larger.scss # docs/_sass/minimal-mistakes/vendor/font-awesome/_list.scss # docs/_sass/minimal-mistakes/vendor/font-awesome/_mixins.scss # docs/_sass/minimal-mistakes/vendor/font-awesome/_path.scss # docs/_sass/minimal-mistakes/vendor/font-awesome/_rotated-flipped.scss # docs/_sass/minimal-mistakes/vendor/font-awesome/_screen-reader.scss # docs/_sass/minimal-mistakes/vendor/font-awesome/_stacked.scss # docs/_sass/minimal-mistakes/vendor/font-awesome/_variables.scss # docs/_sass/minimal-mistakes/vendor/magnific-popup/_magnific-popup.scss # docs/_sass/minimal-mistakes/vendor/magnific-popup/_settings.scss # docs/_sass/minimal-mistakes/vendor/susy/_su.scss # docs/_sass/minimal-mistakes/vendor/susy/_susy.scss # docs/_sass/minimal-mistakes/vendor/susy/_susyone.scss # docs/_sass/minimal-mistakes/vendor/susy/susy/_su.scss # docs/_sass/minimal-mistakes/vendor/susy/susy/language/_susy.scss # docs/_sass/minimal-mistakes/vendor/susy/susy/language/_susyone.scss # docs/_sass/minimal-mistakes/vendor/susy/susy/language/susy/_background.scss # docs/_sass/minimal-mistakes/vendor/susy/susy/language/susy/_bleed.scss # docs/_sass/minimal-mistakes/vendor/susy/susy/language/susy/_box-sizing.scss # docs/_sass/minimal-mistakes/vendor/susy/susy/language/susy/_breakpoint-plugin.scss # docs/_sass/minimal-mistakes/vendor/susy/susy/language/susy/_container.scss # docs/_sass/minimal-mistakes/vendor/susy/susy/language/susy/_context.scss # docs/_sass/minimal-mistakes/vendor/susy/susy/language/susy/_gallery.scss # docs/_sass/minimal-mistakes/vendor/susy/susy/language/susy/_grids.scss # docs/_sass/minimal-mistakes/vendor/susy/susy/language/susy/_gutters.scss # docs/_sass/minimal-mistakes/vendor/susy/susy/language/susy/_isolate.scss # docs/_sass/minimal-mistakes/vendor/susy/susy/language/susy/_margins.scss # docs/_sass/minimal-mistakes/vendor/susy/susy/language/susy/_padding.scss # docs/_sass/minimal-mistakes/vendor/susy/susy/language/susy/_rows.scss # docs/_sass/minimal-mistakes/vendor/susy/susy/language/susy/_settings.scss # docs/_sass/minimal-mistakes/vendor/susy/susy/language/susy/_span.scss # docs/_sass/minimal-mistakes/vendor/susy/susy/language/susy/_validation.scss # docs/_sass/minimal-mistakes/vendor/susy/susy/language/susyone/_background.scss # docs/_sass/minimal-mistakes/vendor/susy/susy/language/susyone/_functions.scss # docs/_sass/minimal-mistakes/vendor/susy/susy/language/susyone/_grid.scss # docs/_sass/minimal-mistakes/vendor/susy/susy/language/susyone/_isolation.scss # docs/_sass/minimal-mistakes/vendor/susy/susy/language/susyone/_margin.scss # docs/_sass/minimal-mistakes/vendor/susy/susy/language/susyone/_media.scss # docs/_sass/minimal-mistakes/vendor/susy/susy/language/susyone/_padding.scss # docs/_sass/minimal-mistakes/vendor/susy/susy/language/susyone/_settings.scss # docs/_sass/minimal-mistakes/vendor/susy/susy/output/_float.scss # docs/_sass/minimal-mistakes/vendor/susy/susy/output/_shared.scss # docs/_sass/minimal-mistakes/vendor/susy/susy/output/_support.scss # docs/_sass/minimal-mistakes/vendor/susy/susy/output/float/_container.scss # docs/_sass/minimal-mistakes/vendor/susy/susy/output/float/_end.scss # docs/_sass/minimal-mistakes/vendor/susy/susy/output/float/_isolate.scss # docs/_sass/minimal-mistakes/vendor/susy/susy/output/float/_span.scss # docs/_sass/minimal-mistakes/vendor/susy/susy/output/shared/_background.scss # docs/_sass/minimal-mistakes/vendor/susy/susy/output/shared/_container.scss # docs/_sass/minimal-mistakes/vendor/susy/susy/output/shared/_direction.scss # docs/_sass/minimal-mistakes/vendor/susy/susy/output/shared/_inspect.scss # docs/_sass/minimal-mistakes/vendor/susy/susy/output/shared/_margins.scss # docs/_sass/minimal-mistakes/vendor/susy/susy/output/shared/_output.scss # docs/_sass/minimal-mistakes/vendor/susy/susy/output/shared/_padding.scss # docs/_sass/minimal-mistakes/vendor/susy/susy/output/support/_background.scss # docs/_sass/minimal-mistakes/vendor/susy/susy/output/support/_box-sizing.scss # docs/_sass/minimal-mistakes/vendor/susy/susy/output/support/_clearfix.scss # docs/_sass/minimal-mistakes/vendor/susy/susy/output/support/_prefix.scss # docs/_sass/minimal-mistakes/vendor/susy/susy/output/support/_rem.scss # docs/_sass/minimal-mistakes/vendor/susy/susy/output/support/_support.scss # docs/_sass/minimal-mistakes/vendor/susy/susy/su/_grid.scss # docs/_sass/minimal-mistakes/vendor/susy/susy/su/_settings.scss # docs/_sass/minimal-mistakes/vendor/susy/susy/su/_utilities.scss # docs/_sass/minimal-mistakes/vendor/susy/susy/su/_validation.scss # docs/assets/css/main.scss # docs/assets/js/main.min.js # docs/assets/js/plugins/jquery.greedy-navigation.js # minimal-mistakes-jekyll.gemspec # test/_config.yml # test/_data/ui-text.yml # test/_pages/terms.md # test/_posts/2010-01-07-post-modified.md # test/_posts/2012-03-15-layout-header-overlay-image.md # test/_posts/2013-08-16-markup-syntax-highlighting.md
kkunapuli
pushed a commit
to kkunapuli/kkunapuli.github.io
that referenced
this pull request
May 30, 2019
makaroniame
added a commit
to makaroniame/makaroniame-old.github.io
that referenced
this pull request
May 18, 2022
jchwenger
pushed a commit
to jchwenger/jchwenger.github.io
that referenced
this pull request
May 5, 2023
koyumi0601
pushed a commit
to koyumi0601/koyumi0601.github.io
that referenced
this pull request
Jul 31, 2023
* Optimize simple navigation cases Fix inefficiency reported in feedback on v0.4.0.rc2 (see discussion mmistakes#958). This PR: * essentially reverts `_includes/nav.html` to v0.4.0.rc1 * preserves the ARIA labels added by mmistakes#950 * adds a test to optimize builds of sites that rely on `title` fields to order pages. Building the `endoflife.date` site (130 pages) now takes only about 7 seconds. Building the `machinetranslate.org` site ( 350 pages) takes about 7 minutes. (Without the added test, it takes just over 5 minutes: the condition of the test is merely to compare the size of two arrays, but that is apparently enough to prevent Jekyll from applying some optimization). A warning is added to the docs about the need for numbers to be in quotes when used as title values. * Update navigation-structure.md A clarification is added to the docs about the need for numbers to be in quotes when used as title values. * Simplify the control and data flow - Defer concatenation of `string_order_pages` with `title_order_pages` until needed. - Replace tests on size with tests for `empty`. - Rename variables accordingly. * Fix child nav order This PR started from the navigation in RC1. Some cosmetic improvements had been made in RC2. This commit adds some of those changes to this PR. It also fixes a bug (revealed by a new regression test) due to a reference to `node.child_nav_order` instead of `child.child_nav_order`, which prevented reversal of the order in children of children. Presumably a top-level reversal should apply only to direct children, and not to grandchildren. The latter interpretation would be very confusing in a deep multi-level hierarchy. * Allow pages with numeric titles An omitted `nav_order` value should default to the `title` value, regardless of its type. Jekyll 3 gives build errors when numbers and strings are sorted together. This commit drops the assumption that `title` values are always strings – a 404 page naturally has a numeric title. It updates the docs page accordingly. The extra code does not affect the build time for the `endoflife.date` site (7 seconds). For the `machinetranslate` site, changing the title of the 404 page to a number increases the build time from 7 minutes to 9 minutes – the `nav_order` numbers on that site are program-generated in the range 1..1000, which might be atypical. This commit has not yet been checked using the regression tests. The gemspec used for testing specifies `spec.add_runtime_dependency "jekyll", "~> 3.8.5"`, and `Gemfile.lock` shows `jekyll (3.8.7)`. * Update nav.html Add comment about an optimization that will be possible in Jekyll 4. * Update nav.html - Update the comment about optimization possibility. - TEMPORARILY add Jekyll 3 code for conditionally optimizing. * Update nav.html Minor improvements and cosmetic changes. * Major revision This update is based on extensive experimentation and profiling with alternative versions of the Liquid code used to build the main navigation panel. Due to the fragility of Jekyll's optimizations, combining alternative approaches with conditionals turned out to be too expensive: merely adding a condition to check whether some array of pages is empty can add about 20% to the build time! The current code avoids sorting pages on `nav_order` and `title` fields together. The standard way of doing that in Jekyll is to use the `group_by` filter; but extracting the sorted pages from the groups turned out to be too inefficient (as seen in RC1), as was generating links directly from the groups (in RC2). Making all pages with `nav_order` values come before all those ordered by their `title` values is not ideal (it doesn't support tweaking the relative order of two pages in a list of pages ordered by their titles) but it appears to be necessary for efficient builds on large sites. This version has not yet been fully tested for regression, but otherwise seems to give the expected navigation on the endoflife.date and machinetranslate websites. (I'm unable to install the Python-based how2data repository on my laptop, due to package version issues on Apple silicon). Co-authored-by: Peter Mosses <[email protected]>
yesterz
pushed a commit
to yesterz/yesterz.github.io-test
that referenced
this pull request
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,i m working on your project and i really love your work,congratulations.It seems that greek language has not been added to the project and this p.r does that!
Thank you.