Add responsive video header and include with docs #788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Quick look and this looks great. I'll have a closer look and let you know. Appreciate you documenting and adding examples too 😄 |
NicolasT
referenced
this pull request
in NicolasT/nicolast.github.io
Jan 29, 2017
* tag '4.2.1': (22 commits) Bump version to 4.2.1 Update CHANGELOG and history Document moving paginated home page to an alternate location Pagination now works for index.html files in subfolders. Links to next page consider baseurl now. (#764) Pagination now works for index.html files in subfolders. Links to next page consider baseurl now. (#764) Add https prefix to google-universal embed code. (#772) Add https prefix to google-universal embed code. (#772) Bump version to 4.2.0 Bump jekyll-sitemap to (1.0) Update CHANGELOG and history Improve video helper documentation Add video header support to `archive` and `splash` layouts Rename `responsive_video` helper to `video` Add some white-space below video embeds Add Nepali (Nepalese) text Add page hero video for vimeo/youtube using embedresponsively.com code (#788) Nepalese Language (#785) invalid `analytics` example fix (#783) Remove borders from table elements found in Google Custom Search Engine widget - Close #759 Complete Simplified Chinese Translation of Theme UI (#747) ...
wetty
added a commit
to wetty/wetty-web
that referenced
this pull request
Feb 7, 2017
…into gh-pages * 'master' of https://github.com/mmistakes/minimal-mistakes: (22 commits) Bump version to 4.2.1 Update CHANGELOG and history Document moving paginated home page to an alternate location Pagination now works for index.html files in subfolders. Links to next page consider baseurl now. (mmistakes#764) Pagination now works for index.html files in subfolders. Links to next page consider baseurl now. (mmistakes#764) Add https prefix to google-universal embed code. (mmistakes#772) Add https prefix to google-universal embed code. (mmistakes#772) Bump version to 4.2.0 Bump jekyll-sitemap to (1.0) Update CHANGELOG and history Improve video helper documentation Add video header support to `archive` and `splash` layouts Rename `responsive_video` helper to `video` Add some white-space below video embeds Add Nepali (Nepalese) text Add page hero video for vimeo/youtube using embedresponsively.com code (mmistakes#788) Nepalese Language (mmistakes#785) invalid `analytics` example fix (mmistakes#783) Remove borders from table elements found in Google Custom Search Engine widget - Close mmistakes#759 Complete Simplified Chinese Translation of Theme UI (mmistakes#747) ... # Conflicts: # CHANGELOG.md # README.md # docs/_data/ui-text.yml # docs/_docs/05-configuration.md # docs/_docs/08-ui-text.md # docs/_docs/10-layouts.md # docs/_docs/14-helpers.md # docs/_docs/17-javascript.md # docs/_docs/18-history.md # docs/_includes/analytics-providers/google-universal.html # docs/_includes/page__hero.html # docs/_includes/paginator.html # docs/_layouts/archive.html # docs/_layouts/single.html # docs/_layouts/splash.html # docs/_pages/about.md # docs/_pages/home.md # docs/_sass/_utilities.scss # docs/assets/js/_main.js # docs/assets/js/main.min.js # minimal-mistakes-jekyll.gemspec # test/_data/ui-text.yml
ghost
reviewed
Apr 10, 2017
| <!-- Courtesy of embedresponsively.com //--> | ||
| <div class="responsive-video-container"> | ||
| {% if video_provider == "vimeo" %} | ||
| <iframe src="http:https://player.vimeo.com/video/{{ video_id }}" frameborder="0" webkitAllowFullScreen mozallowfullscreen allowFullScreen></iframe> |
There was a problem hiding this comment.
Hey should these be protocol relative? This breaks when served over HTTPS
There was a problem hiding this comment.
Yes it should be protocol relative.
There was a problem hiding this comment.
Maybe just do https://, I just checked the embeds on Vimeo and that's what they default to. The YouTube one is that way as well.
ghost
mentioned this pull request
kkunapuli
pushed a commit
to kkunapuli/kkunapuli.github.io
that referenced
this pull request
May 30, 2019
makaroniame
added a commit
to makaroniame/makaroniame-old.github.io
that referenced
this pull request
May 18, 2022
jchwenger
pushed a commit
to jchwenger/jchwenger.github.io
that referenced
this pull request
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up fixes for #781:
Additional enhancements:
_includes/page__hero_video.htmlinto_includes/responsive_video_includes/page__hero_video.htmlto use{% include responsive_video id="..." provider="..." %}Let me know if there's any further modifications required for merging. Thanks! =)