Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Social Sharing links section #4066

Merged
merged 2 commits into from
May 5, 2024
Merged

Update Social Sharing links section #4066

merged 2 commits into from
May 5, 2024

Conversation

jstrong013
Copy link
Contributor

This is a documentation change.

Summary

Update social sharing section for appropriate Reddit example and resource locations.

Context

Could use a second set of eyes. Open to edits.

Related to Issue #1656 and pull request #1657

@jstrong013
Update 10-layouts.md
bc76650 
Update social sharing section for appropriate Reddit example and resource locations.
iBug
iBug requested changes May 5, 2024
View reviewed changes
Copy link
Collaborator

@iBug iBug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for the unnecessary onclick attribute. Might be better to keep it simple in the documentation.

Also default: 'Share on' is not required. There's more to break if site.locale is nonsensical.

@iBug iBug merged commit 0378a31 into mmistakes:master May 5, 2024
1 check passed
@jstrong013 jstrong013 deleted the reddit-social-share-docs branch May 17, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iBug iBug iBug requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jstrong013 @iBug