Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ load latest fontawesome package #3765

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

marciska
Copy link
Contributor

@marciska marciska commented Jul 10, 2022

This is an enhancement or feature.

Summary

Upgrade to the newest fontawesome package.
Until now the package has been fixed at version 5.0.0 and has thus never received any bugfixes.
By changing the @5 to @latest in the version tag, minimal-mistakes now ships always with the newest up-to-date version.
(Currently, 6.1.1 is the newest)

Context

I am a researcher and therefore active on many research-related social platforms. I needed some icons that were introduced in later patch-versions of fontawesome version 5, so I had to manually overwrite the head.html just to get the newest version. I believe that minimal-mistakes should always ship with the newest patch-version, as 5.0.0 is very outdated and does not include any patches that came after.
I am aware that minimal-mistakes should be kept minimal (and therefore not all requests can be met that only target specific individuals), but I assume that this patch should come in handy for a large-user base as there is no reason to limit ourselves to an old version if we can dynamically load always the latest release with @latest.

@iBug
Copy link
Collaborator

iBug commented Jul 10, 2022

FYI, the front page of jsDelivr shows that @3 means any version with major=3. So the current implementation does automatically load the latest 5.x version of Font Awesome (currently 5.15.4). It does not, as you've noticed, load any FA v6.

@mmistakes mmistakes merged commit 51fcef5 into mmistakes:master Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants