Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

How to embed a pdf file inside my GitHub page with minimal-mistakes? #2361

Closed
mihirp161 opened this issue Jan 3, 2020 · 6 comments
Closed

How to embed a pdf file inside my GitHub page with minimal-mistakes? #2361

mihirp161 opened this issue Jan 3, 2020 · 6 comments
Labels
Type: Support

Comments

@mihirp161
Copy link

I have made a pdf.html file inside the _layouts folder, code in it as follows:

{% highlight html %}    
{% raw %}       
   <!DOCTYPE html>       
       <html>       
        {% include head.html %}    
           <body>
              {{ content }}   
           </body>     
        </html>   
 {% endraw %}    
 {% endhighlight %}

Then a resume.md file with the following:

  ---
 title: "Résumé"
 layout: pdf
 permalink: /resume/
 ---

  <iframe src="https://drive.google.com/file/d/1gTkiMqqYOYQv8PmhzC559x51Pfc9cj36/preview" width="640" height="480"></iframe>

I then added an appropriate navigation in _data folder too. But I don't see any embedded pdf in my GitHub pages. I will appreciate if you help me out.
@mihirp161 mihirp161 changed the title How to embedd a pdf file inside my GitHub page in this theme? How to embed a pdf file inside my GitHub page in this theme? Jan 3, 2020
@mihirp161 mihirp161 changed the title How to embed a pdf file inside my GitHub page in this theme? How to embed a pdf file inside my GitHub page with minimal-mistakes? Jan 3, 2020
@mmistakes
Copy link
Owner

You need to link to the PDF. I don’t see anywhere you’ve done that.

@mmistakes
Copy link
Owner

This doesn’t appear to be a theme issue either. You might want to dig into Jekyll/GitHub Pages support.

@mihirp161
Copy link
Author

hello, I have tried this prior:

---
title: "Résumé"
permalink: /resume/
header:
---
[See it here :)](http:https://ToadHanks.github.io/images/mihir_resume_2019v5.pdf)

Then I get a link that opens to new tab instead of a pdf embedded page. However, I have saved to pdf to image, and was able to display that in the page.

@mihirp161
Copy link
Author

Update: Actually you're 100% correct, I should have sent the question to Jekyll. This problem is not related to the theme you made. Apologies sir.

@ashesh-0
Copy link

Just for completeness sake, below is a pdf embedding example.

Code: https://raw.githubusercontent.com/belovanna/belovanna.github.io/b64e6c285e0e057f9bc9a1723a4eb767446a1947/_pages/curriculum.md
Effect: https://belovanna.github.io/Curriculum/

I felt using classes: wide makes it better.

@mihirp161
Copy link
Author

Thanks @ashesh-0 Appreciate the input.

pivdnber added a commit to pivdnber/pivdnber.github.io that referenced this issue Aug 1, 2022
@pivdnber
change CV
4af6a23 
see example mmistakes/minimal-mistakes#2361
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Support
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mmistakes @ashesh-0 @mihirp161