Remove pydicom from requirements #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephdviviano
approved these changes
Mar 1, 2022
There was a problem hiding this comment.
I can't see the diffs from the notebook.
I think this is totally fine. I've seen this pattern before. A better solution would be to fully replace the use of pydicom with something more lightweight but that's a lot of work and potentially not really worth the effort.
|
We should just make sure to clearly document the pydicom version that should be installed if the user wants to use the dataloaders, just to avoid nasty python environment mistakes which are extremely hard for the end user to debug. |
|
It seems the existing requirement was for pydicom>=1 and the current version is 2.2.2 so it seems not such a big deal for the version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on a reviewers comment I'm making this PR. I agree it is hard to have pydicom as a requirement because it pretty low level so it could have issues installing and most of the datasets don't need it.
My concern is that I'm doing it is inefficient.