Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pylint check to PR #707

Closed
wants to merge 6 commits into from
Closed

Pylint check to PR #707

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2843e12
added lint check to PR checks.
DanielAvdar Feb 12, 2024
c63d38d
move pylint to pylint.yml.
DanielAvdar Feb 12, 2024
d090d96
add black dependency.
DanielAvdar Feb 12, 2024
5e85a5c
rename pylint.yml job name.
DanielAvdar Feb 12, 2024
eb3c17b
remove unused step, added mypy as optional check.
DanielAvdar Feb 18, 2024
0410794
add pylint and mypy to dev-dependencies.
DanielAvdar Feb 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
move pylint to pylint.yml.
  • Loading branch information
@DanielAvdar
DanielAvdar committed Feb 12, 2024
commit c63d38dfa858be8dbf48ec3f07247201ad0c13fa
25 changes: 25 additions & 0 deletions .github/workflows/pylint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
name: Tests

on: [ push,pull_request ]

jobs:

pylint:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- name: Set up Python "3.10"
uses: actions/setup-python@v3
with:
python-version: "3.11"
- name: Install dependencies
run: |
python -m pip install --upgrade pip
pip install pylint
- name: Analysing the code with pylint
run: |
pylint ./supervised --fail-under=6
- name: Black + pylint
run: |
black ./supervised
pylint ./supervised --fail-under=6
15 changes: 0 additions & 15 deletions .github/workflows/run-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,18 +45,3 @@ jobs:
run: |
pytest tests --cov=supervised/
continue-on-error: true
pylint:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- name: Set up Python "3.10"
uses: actions/setup-python@v3
with:
python-version: "3.11"
- name: Install dependencies
run: |
python -m pip install --upgrade pip
pip install pylint
- name: Analysing the code with pylint
run: |
pylint ./supervised --fail-under=7