Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update object-detector.md #822

Merged
merged 1 commit into from
Mar 12, 2020
Merged

Update object-detector.md #822

merged 1 commit into from
Mar 12, 2020

Conversation

DilwoarH
Copy link
Contributor

@DilwoarH DilwoarH commented Mar 12, 2020

Dear ml5 community,

I'm making a Pull Request(PR). Please see the details below.

This change fixes an error on the documentation.

Before

yolo.detect(video, (err, results) => {
  console.log(results); // Will output bounding boxes of detected objects
});

After

objectDetector.detect(video, (err, results) => {
  console.log(results); // Will output bounding boxes of detected objects
});

@bomanimc bomanimc merged commit b7e7d7d into ml5js:gh-pages Mar 12, 2020
@bomanimc
Copy link
Member

@DilwoarH thank you so much for this change! Going to merge this in now! (cc @joeyklee for visibility)

@joeyklee
Copy link
Contributor

Excellent!
@bomanimc - usually for these cases if a contributor is not already on our contributors list, we add them in using the all-contributor's bot like so:

@all-contributors please add @DilwoarH for content

@allcontributors
Copy link
Contributor

@joeyklee

I could not determine your intention.

Basic usage: @all-contributors please add @Someone for code, doc and infra

For other usages see the documentation

@joeyklee
Copy link
Contributor

@all-contributors please add @DilwoarH for doc

@allcontributors
Copy link
Contributor

@joeyklee

I've put up a pull request to add @DilwoarH! 🎉

bomanimc pushed a commit that referenced this pull request Mar 12, 2020
bomanimc pushed a commit that referenced this pull request Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants