Linting errors for Crepe class #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shiffman
commented
Jun 1, 2018
| const strlen = result.length; | ||
| for (let i = 0; i < 11 - strlen; i++) result = result; | ||
| const result = (confidence > 0.5) ? `${predictedHz.toFixed(3)} + Hz` : 'no voice'; | ||
| // const strlen = result.length; |
There was a problem hiding this comment.
@handav this code didn't seem to be doing anything so I commented it out?
shiffman
commented
Jun 1, 2018
| for (var bufferSize = 4; bufferSize < minBufferSize; bufferSize *= 2); | ||
| console.log('Buffer size = ' + bufferSize); | ||
| const minBufferSize = (this.audioContext.sampleRate / 16000) * 1024; | ||
| let bufferSize = 4; |
There was a problem hiding this comment.
this could probably be written in a different way?
cvalenzuela
approved these changes
Jun 4, 2018
|
I'm going to go ahead and merge this. @cvalenzuela There was a conflict with the built ml5 files I think I resolved correctly but obviously go ahead and rebuild if necessary. |
|
Sorry I've been MIA on this, thanks so much for taking care of this! |
joeyklee
pushed a commit
that referenced
this pull request
Jun 2, 2019
Linting errors for Crepe class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I adjusted the code to fix up the linting errors in the Crepe class and added the Crepe model back into
index.js. I tested the examples and they work now!