Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added links to Discord #1250

Merged
merged 2 commits into from
Jan 19, 2022
Merged

Added links to Discord #1250

merged 2 commits into from
Jan 19, 2022

Conversation

tlsaeger
Copy link
Member

Dear ml5 community,

I'm making a Pull Request(PR). Please see the details below.

A good PR 🌟

→ Step 1: Describe your Pull Request 📝

Fixing a Bug? Adding an Update? Submitting a New Feature? Does it introduce a breaking change?

I added two links to our Discord to the documentation one under »Join our Community« and one at »Contribute to ml5.js«
Might be cool to add it in more places as well. Could be cool to put it in the nav next to the GitHub icon.

I just saw, that there is no link to discord anywhere on the website. Added it in two places, maybe it could even be added in other places as well.
Copy link
Member

@shiffman shiffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for missing this before, I think it's great and good to merge!

Copy link
Contributor

@joeyklee joeyklee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY! 🎉

@joeyklee joeyklee merged commit c2c8f2e into main Jan 19, 2022
@joeyklee joeyklee deleted the tlsaeger-discord branch January 19, 2022 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants