Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Devops] chore: rm reviewdog eslint #1130

Merged
merged 1 commit into from
Jan 12, 2021

Conversation

joeyklee
Copy link
Contributor

@joeyklee joeyklee commented Jan 6, 2021

Dear ml5 community,

I'm making a Pull Request(PR). Please see the details below.

A good PR 🌟

β†’ Step 1: Describe your Pull Request πŸ“

Fixing a Bug? Adding an Update? Submitting a New Feature? Does it introduce a breaking change?

This PR is aimed to temporarily remove the eslint reviewdog Github Action that seems to be running out of memory with our big library. I'm hoping that we can reintegrate the linting tests once we figure out what is going on, but for now, this simply removes the linting automated github action.

My hope with this PR is that we can review/merge in some of the PR requests without the github action errors preventing us from proceeding.

@joeyklee joeyklee added the devops label Jan 6, 2021
@joeyklee joeyklee marked this pull request as ready for review January 6, 2021 03:18
Copy link
Member

@shiffman shiffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am good with this, thank you @joeyklee!

@joeyklee
Copy link
Contributor Author

I will merge this in to main and we can see if this gives us a chance to address some of the other PRs πŸ‘€

@joeyklee joeyklee merged commit 4072578 into main Jan 12, 2021
@joeyklee joeyklee deleted the joeyklee.devops-rm-reviewdog-action branch January 12, 2021 00:39
@bomanimc
Copy link
Member

Unfortunate! I'll also try to take a look to see what's happening here. We may benefit from some local linting checks that run when people create commits in their forked repos, similar to what p5.js-web-editor has in place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants