Allow for debug: "true" in ml5.neuralNetwork #1118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bomanimc
requested changes
Dec 18, 2020
Co-authored-by: Daniel Shiffman <[email protected]>
bomanimc
approved these changes
Feb 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
→ Step 1: Describe your Pull Request 📝
This is a very minor fix for an issue I encountered when making a video tutorial on image classification. The debug visualization does not show up properly if debug is set to the string
"true".While the boolean literal (below) is preferred, it took me a very long time to discover the issue and I think it's a mistake others might make and we might as well allow it as the intention is clear.