Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CVAE example issues on main #1085

Merged
merged 1 commit into from
Oct 22, 2020
Merged

Fix CVAE example issues on main #1085

merged 1 commit into from
Oct 22, 2020

Conversation

bomanimc
Copy link
Member

@bomanimc bomanimc commented Oct 22, 2020

Fixes some issues happening in the CVAE model due to an imported function from p5Utils. This PR simply corrects the import issue. Also fixed some tabbing issues while here.

Rather than importing a single class method (which is possible), I'm just importing the full class and calling the method. I think this is fine and a bit clearer than exporting a single function from the class.

Screen Shot 2020-10-22 at 12 45 01 PM

Copy link
Member

@shiffman shiffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bomanimc bomanimc merged commit 3cfd0a5 into main Oct 22, 2020
@bomanimc bomanimc deleted the bomani.fix-cvae-on-main branch October 22, 2020 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants