Inline and simplify sketch.js in DCGAN example #1074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`sketch.js` is ~50 lines, but it can be simplified to about 9 lines
bomanimc
approved these changes
Oct 15, 2020
There was a problem hiding this comment.
This change makes sense to me! I think it makes the core functionality in the example easier to understand since there's less code associated with creating the canvas elements and buttons. That said, most of our examples do not use inline JS code, so we might be breaking consistency. Overall, I still feel that this would be a good change to merge in.
shiffman
approved these changes
Oct 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
→ Step 1: Which branch are you submitting to? 🌲
Development
→ Step 2: Describe your Pull Request 📝
This just simplifies the
examples/javascript/DCGAN/DCGAN_Randomexample by inlining the ~50 linesketch.jsand reducing it down to about 10 lines.→ Step 3: Share a Relevant Example 🦄
No codepen/fiddle since I don't think I'd be able to host the models shards anywhere?Just realised that the face model somehow loads from github (thought there'd be CORs issues): https://jsbin.com/posihevawe/2/edit?html,output
→ Step 4: Screenshots or Relevant Documentation 🖼
It works just the same as before:
Thanks! 🌈
Joe