Add a test and additional example for Facemesh #1024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! @bomanimc - One thing I was thinking could be interesting is to add a few data helpers (this could be a subsequent PR for anther time) for getting back parts of the mesh -- e.g. "eye" would be an array of points [133, 155, etc] -- https://github.com/tensorflow/tfjs-models/blob/master/facemesh/mesh_map.jpg. |
|
Yeah adding some of those east getters for keypoints would be really cool! I opened #1028 to track. |
bomanimc
force-pushed
the
bomani.facemesh-tests
branch
from
6e5a54e
to
757fbcf
Compare
joeyklee
reviewed
Jul 19, 2020
| let facemeshInstance; | ||
| let testImage; | ||
|
|
||
| async function loadHTMLImageElement(imageSrc) { |
There was a problem hiding this comment.
as side note: we should extract out these loadImage functions in to some kind of testing utils module :)
There was a problem hiding this comment.
for another PR though. Let's keep this for now.
joeyklee
approved these changes
Jul 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces an example showing a single image use case for Facemesh, as well as a test that ensures that Facemesh can correctly identify a face in an image from a CDN. Fixes #988.
Test Plan
npm run test -- --model=facemeshnpm run developand visit http:https://127.0.0.1:8081/p5js/Facemesh/Facemesh_Image/