move has no effect on const variables #1333
Open
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awni
reviewed
Aug 16, 2024
| @@ -977,7 +977,7 @@ std::vector<array> Convolution::vjp( | |||
| } | |||
| } | |||
|
|
|||
| grad = slice(grad, std::move(starts), std::move(stops), stream()); | |||
awni
reviewed
Aug 16, 2024
| @@ -824,7 +824,7 @@ std::function<std::vector<array>(const std::vector<array>&)> compile( | |||
| // Mark the entry as not empty since we are about to fill it | |||
| entry.empty = false; | |||
| // Set the constants | |||
| entry.constants = std::move(constants); | |||
angeloskath
requested changes
Aug 16, 2024
| @@ -824,7 +824,7 @@ std::function<std::vector<array>(const std::vector<array>&)> compile( | |||
| // Mark the entry as not empty since we are about to fill it | |||
| entry.empty = false; | |||
| // Set the constants | |||
| entry.constants = std::move(constants); | |||
| entry.constants = constants; | |||
There was a problem hiding this comment.
The constants are actually passed by value here or did I miss something.
| @@ -331,7 +331,7 @@ void Softmax::eval_cpu(const std::vector<array>& inputs, array& out) { | |||
| return x_copy; | |||
| } | |||
| }; | |||
| array in = check_input(std::move(inputs[0])); | |||
| array in = check_input(inputs[0]); | |||
There was a problem hiding this comment.
Nice, this was left because initially it was written like this
array in_pre = inputs[0]; // copy first
auto in = check_input(std::move(in_pre));
| @@ -977,7 +977,7 @@ std::vector<array> Convolution::vjp( | |||
| } | |||
| } | |||
|
|
|||
| grad = slice(grad, std::move(starts), std::move(stops), stream()); | |||
| grad = slice(grad, starts, stops, stream()); | |||
There was a problem hiding this comment.
Slice takes its arguments by value. What we should actually do is check if there are places that could pass by move yet pass by copy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Remove std::move for const variables
Please include a description of the problem or feature this PR is addressing. If there is a corresponding issue, include the issue #.
Checklist
Put an
xin the boxes that apply.pre-commit run --all-filesto format my code / installed pre-commit prior to committing changes