Fix table's within tables bug #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -420,8 +420,8 @@ | |||
| } | |||
| $table.css(layoutFixed); | |||
| $floatTable.css(layoutFixed); | |||
| $header.after($newHeader); | |||
There was a problem hiding this comment.
For some reason
$tbody.before($newHeader);
Was not working at all in this two table scenario. I could not figure it out, so I tried this (which should be the same outcome) and it worked.
There was a problem hiding this comment.
Ill need to find out the exact reason why this change is required before i merge this - not to be a pain - but it might be a symptom of some other bug
|
I created a clean test without that change and it seems to work now. It must have been something in my specific use case in my other project. I've worked around it differently on my project, but it seems to me the Regardless, here's just the |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nested tables inside the floated table header were having odd issues. These changes force floatThead to use only the thead/tbody belonging directly to the selected table(s).
Bug: http:https://jsfiddle.net/z9t1wmg8/4/
In this example, the size-row gets inserted in the wrong table.