Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

error in opt validation check #62

Closed
thompsk opened this issue Mar 18, 2014 · 4 comments
Closed

error in opt validation check #62

thompsk opened this issue Mar 18, 2014 · 4 comments

Comments

@thompsk
Copy link

thompsk commented Mar 18, 2014

line 148 the key is being checked against the floatThead.defaults rather than the val giving spurious debug comments
@mkoryak
Copy link
Owner

mkoryak commented Mar 18, 2014

Thanks, will fix

@mkoryak
Copy link
Owner

mkoryak commented Mar 21, 2014

Ah, this is because $.map's callback is function(key, val) while _.map uses function(val, key) - noted.

mkoryak added a commit that referenced this issue Mar 21, 2014
@mkoryak
fixes for #62, #65, #66
af14927
@mkoryak
Copy link
Owner

mkoryak commented Mar 24, 2014

fixed in 1.2.5

@mkoryak mkoryak closed this as completed Mar 24, 2014
@lock
Copy link

lock bot commented Dec 11, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mkoryak @thompsk