New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewording How Fork is Described #36

Open

qiongsiwu wants to merge 1 commit into mit-pdos:xv6-riscv from qiongsiwu:qw_fix_process_and_memory_fork

qiongsiwu commented Oct 19, 2023

The current text states that

fork gives the new process an exact copy of the calling process's memory, both instruction and data.

A few sentences above, the text states that

An xv6 process consists of user-space memory (instructions, data, and stack) ...

The combination of these two sentences may imply that "stack" is not cloned during fork, and the code https://github.com/mit-pdos/xv6-riscv/blob/f5b93ef12f7159f74f80f94729ee4faabe42c360/kernel/proc.c#L292 implies that we are copying the whole user-space memory, including instructions, data, and stack.

This PR rewords the sentence that describes fork to reduce ambiguity.


Rewording the sentence about fork to reduce ambiguity

6afe747

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment