-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Azure AI Search Integration with Mistral RAG #38
Conversation
@pablocastro @chuwik plz review :) |
@sophiamyang @pandora-s-git @hrjn plz review :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a comment to update a broken link, otherwise looking good thanks for getting this done!
@farzad528 I still see the old link even though the comment is resolved. |
updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments, looks good to me with that feedback incorporated.
General style nit: there are many cells that contain a function that's called just once and within the same cell, not sure if you gain much in readability by doing that versus just having the body of the method be the code for the whole cell. Same for variables that have a constant assigned just to be used once within the cell.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Left a couple of small comments. Also the readme seems to have some churn, not sure if adding an entry to the table shifted everything down (which is fine) or if you need to pull from main to pick up latest changes.
why is this PR closed? @farzad528 are you going to make another one? |
@sophiamyang sorry was just pulling latest from main! |
cool does this notebook run successfully on colab and let me know when it's ready to be merged. |
@sophiamyang Yes! I tested e2e on colab as well! Ready to be merged! Tysm for putting this together! Would love to share this with Azure AI customers! |
@sophiamyang ready to merge! |
Awesome thanks so much! |
This PR introduces a new notebook
azure_ai_search_rag.ipynb
that demonstrates the integration of Azure AI Search with Mistral's RAG model.In this notebook, we install the necessary packages including
azure-search-documents
,azure-identity
,datasets
, andmistralai
. We then use Azure AI Search to fetch documents and Mistral's RAG model to generate responses based on the fetched documents and a user query.This example provides a practical use case of combining Azure AI Search with Mistral's RAG model, and can serve as a starting point for developers looking to integrate these technologies in their applications. Also, note that Mistral customers can use both the Mistral API Key AND the Azure AI Studio Serverless API for Chat Completion Model Hosting.
Note, at this time Azure AI Studio does NOT support Mistral Embeddings, only the Chat Completion models (e.g. mistral-large)