enhance: show renoters #7954

Johann150 · 2021-11-04T23:12:10Z

What

A tooltip is added to show who has renoted a note.

I am not sure if these two additional things should be done:

a separate tooltip component can be created.
merit: look cleaner.
demerit: causes some duplicated code.
Currently, the reaction component is reused with the 🔁 emoji. It looks like this:
add a data field to the api/notes/show endpoint to be able to show when a note was renoted, without an extra API request. see その投稿をRenoteしたユーザー一覧を表示 #4438 (comment)
This might even be necessary because the number of renoters is limited to 11 which might not include our own renote.
merit: show user if they have shared a note before, prevent accidentall duplicate renote
demerit: could cause additional database and server load

Why

okpierre · 2021-11-05T01:51:13Z

I noticed your screen shot also shows duplicate emojis similar to #6805 opened a year ago. Will this PR also include a fix for that?

Johann150 · 2021-11-05T07:14:23Z

No, that is off topic.

Johann150 · 2021-11-05T10:38:50Z

renote.details.vue already uses the style changes from #7942

Johann150 · 2021-11-05T10:40:11Z

Unless you ask, I am not going to change the API here (2nd item on the checklist), because I think that can be a separate issue.

Johann150 · 2021-11-05T11:30:51Z

updated screenshot:

For now the renoters tooltip just uses the reaction viewer component with a fixed emoji symbol instead.

Johann150 · 2021-11-11T17:59:10Z

has been rebased onto the refactoring

syuilo

components/renote.vue よりも components/renote-button.vue の方が分かりやすいと思います😉

syuilo · 2021-11-12T12:25:30Z

packages/client/src/components/note.vue

-import { pleaseLogin } from '@/scripts/please-login';
-import { focusPrev, focusNext } from '@/scripts/focus';
-import { url } from '@/config';
-import copyToClipboard from '@/scripts/copy-to-clipboard';
-import { checkWordMute } from '@/scripts/check-word-mute';
-import { userPage } from '@/filters/user';
-import * as os from '@/os';
-import { noteActions, noteViewInterruptors } from '@/store';
-import { reactionPicker } from '@/scripts/reaction-picker';
-import { extractUrlFromMfm } from '@/scripts/extract-url-from-mfm';
+import XRenoteButton from './renote.vue';
+import { pleaseLogin } from '@client/scripts/please-login';
+import { focusPrev, focusNext } from '@client/scripts/focus';
+import { url } from '@client/config';
+import copyToClipboard from '@client/scripts/copy-to-clipboard';
+import { checkWordMute } from '@client/scripts/check-word-mute';
+import { userPage } from '@client/filters/user';
+import * as os from '@client/os';
+import { noteActions, noteViewInterruptors } from '@client/store';
+import { reactionPicker } from '@client/scripts/reaction-picker';
+import { extractUrlFromMfm } from '@/misc/extract-url-from-mfm';


@client/~ではなく@/~の方が正しいです。

I don't understand, I thought that was refactored?

In this commit, @client has been replaced by @.
Well, I'll fix it after the merge, so no worries.

Thanks ❤️

syuilo · 2021-11-12T14:15:21Z

🆒

@click

* feat: thread mute (misskey-dev#7930) * feat: thread mute * chore: fix comment * fix test * fix * refactor * feat: クライアントでログインするアカウントidを指定するクエリ(loginId=:userId) (misskey-dev#7929) * feat: ログインするアカウントのIDをクエリ文字列で指定する機能 * await? * rename * ユーザー情報のhasUnreadChannelが常にfalseになってしまっているのを修正 (misskey-dev#7938) * fix: 削除したノートやユーザーがリモートから参照されると復活することがあるのを修正 (misskey-dev#7918) * Fix misskey-dev#7557 * CHANGELOG * Fix user * CHANGELOG * Tune CHANGELOG * Tune CHANGELOG * resolver * Remove check * Remove import * CHANGELOG * Tune Co-authored-by: syuilo <[email protected]> * stop context menu handling for videos (misskey-dev#7927) * chore(client): Fix misskey-dev#7923 Close misskey-dev#7924 * Update emojis.vue (misskey-dev#7915) * fix(client): ページ編集時のドロップダウンメニューなどが動作しない問題を修正 * fix(client): コントロールパネルのカスタム絵文字タブが切り替わらないように見える問題を修正 * New Crowdin updates (misskey-dev#7913) * New translations ja-JP.yml (Arabic) * New translations ja-JP.yml (Arabic) * New translations stream.md (Arabic) * New translations ja-JP.yml (Arabic) * New translations links.md (Arabic) * New translations ja-JP.yml (Arabic) * New translations ja-JP.yml (Arabic) * New translations timeline.md (English) * New translations pages.md (English) * New translations timeline.md (English) * New translations keyboard-shortcut.md (English) * New translations theme.md (English) * New translations theme.md (English) * New translations ja-JP.yml (Arabic) * New translations glossary.md (Arabic) * New translations note.md (Arabic) * New translations ja-JP.yml (Arabic) * New translations ja-JP.yml (Arabic) * New translations ja-JP.yml (Arabic) * New translations note.md (Arabic) * New translations share-page.md (Arabic) * New translations ja-JP.yml (Arabic) * New translations ja-JP.yml (Arabic) * New translations ja-JP.yml (Arabic) * New translations ja-JP.yml (Arabic) * New translations ja-JP.yml (Arabic) * New translations ja-JP.yml (Arabic) * New translations ja-JP.yml (Arabic) * New translations ja-JP.yml (Arabic) * New translations ja-JP.yml (Arabic) * New translations ja-JP.yml (Arabic) * New translations ja-JP.yml (Arabic) * New translations ja-JP.yml (Arabic) * New translations ja-JP.yml (Arabic) * New translations ja-JP.yml (Arabic) * New translations ja-JP.yml (Esperanto) * New translations share-page.md (Esperanto) * New translations share-page.md (Esperanto) * New translations share-page.md (Esperanto) * New translations share-page.md (Esperanto) * New translations share-page.md (Esperanto) * New translations share-page.md (Esperanto) * New translations share-page.md (Esperanto) * New translations custom-emoji.md (Portuguese) * New translations theme.md (Portuguese) * New translations widgets.md (Portuguese) * New translations ja-JP.yml (Arabic) * New translations ja-JP.yml (Arabic) * New translations ja-JP.yml (Arabic) * New translations ja-JP.yml (Arabic) * New translations ja-JP.yml (Arabic) * New translations ja-JP.yml (Arabic) * New translations ja-JP.yml (Arabic) * New translations ja-JP.yml (Arabic) * New translations ja-JP.yml (Arabic) * New translations ja-JP.yml (Arabic) * New translations ja-JP.yml (English) * New translations ja-JP.yml (German) * 🎨 * Update CHANGELOG.md * 12.95.0 * add some locales Resolve misskey-dev#7940 * refactor: Introduce list of MFM Functions (misskey-dev#7882) * introduce list of MFM Functions * add note * enhane: 完全ログアウト時にすべてのタブがウェルカムページへ移動するように (misskey-dev#7928) * enhane: unison-reloadに指定したパスに移動できるように * null * null * null * add comments * limit menu list size (misskey-dev#7950) This can be an issue for example when adding an object to the room. * Update CHANGELOG.md * fix missing i18n string (misskey-dev#7945) * fix html conversion issue with code blocks (misskey-dev#7943) * コントロールパネルのジョブキューに個々のジョブが表示されないのを修正 (misskey-dev#7941) * Update CHANGELOG.md * Update abuses.vue * fix(client): Add missing localization string (misskey-dev#7944) * 欠けるi18nストリングの追加 * Update ja-JP.yml Co-authored-by: syuilo <[email protected]> * ドキュメントをmisskey-hubに移行 * 🎨 * misskey-dev#7892 * perf: delete-account処理を軽くする (misskey-dev#7958) * Revert "misskey-dev#7892" This reverts commit 71d9c2a. * アカウント削除処理でノート削除を重複して行なわないようにする * ドライブファイル削除時に参照しているノートを削除しないようにする * 不要となったコードを削除する * feat: make possible to configure following/followers visibility (misskey-dev#7959) * feat: make possible to configure following/followers visibility * add test * ap * add ap test * set Cache-Control * hide following/followers count * feat: improve email validation * feat: インスタンスプロフィールレンダリング Resolve misskey-dev#7788 * fix * 🎨 * feat(client): 通知のリアクションアイコンをホバーで拡大できるように * 🎨 * update deps * refactoring Resolve misskey-dev#7779 * Update CONTRIBUTING.md * add install/build scripts * use eslint * fix lint errors * improve lint * typo * add clean script * Update Dockerfile * fix test * test * fix e2e test * fix bug * Bump cypress from 8.5.0 to 9.0.0 (misskey-dev#7972) Bumps [cypress](https://github.com/cypress-io/cypress) from 8.5.0 to 9.0.0. - [Release notes](https://github.com/cypress-io/cypress/releases) - [Changelog](https://github.com/cypress-io/cypress/blob/develop/.releaserc.base.js) - [Commits](cypress-io/cypress@v8.5.0...v9.0.0) --- updated-dependencies: - dependency-name: cypress dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * refactor * viaMobileフラグ廃止 Close misskey-dev#7965 * clean up * refactoring: グローバルコンポーネントを認識するように * fix errors * fix errors * fix: mention local users in replies (misskey-dev#7975) * mention local users in replies * fix merge * Update CHANGELOG.md * clean up * update ms to 3.0.0 * Update CHANGELOG.md * feat: 通報があったときに管理者へEメールで通知されるように Resolve misskey-dev#7025 * refactor * refactoring * enhance: show renoters (misskey-dev#7954) * refactor: deduplicate renote button into component For now the renoters tooltip just uses the reaction viewer component with a fixed emoji symbol instead. * chore: remove unnecessary CSS * fix: forgot to rename variable * enhance: use own tooltip instead of reaction viewer * clean up style * fix additional renoters number * rename file to better represent content * refactor(client): use composition api for tooltip logic * refactor(client): improve readability * Update CHANGELOG.md * New Crowdin updates (misskey-dev#7977) * New translations ja-JP.yml (Turkish) * New translations ja-JP.yml (Turkish) * New translations ja-JP.yml (Turkish) * New translations ja-JP.yml (Turkish) * New translations ja-JP.yml (French) * New translations ja-JP.yml (French) * New translations ja-JP.yml (Indonesian) * New translations ja-JP.yml (Indonesian) * New translations ja-JP.yml (Indonesian) * fix(client): reaction viewer layout (misskey-dev#7942) The profile picture and name should be grouped together as they belong, and it should be clear which picture belongs to which name. * Update CHANGELOG.md * 12.96.0 * npm scriptの互換性を修正 * add alias to improve compatibility * 12.96.1 * Update .eslintrc.js * fix for lint * Update build.js * Fix v12.96.x Docker (misskey-dev#7982) * fix(client): improve error handling * fix(client): fix tooltip style * feat(client): アカウント削除に確認ダイアログを出すように * fix(client):fix search all users (misskey-dev#7993) * Update CHANGELOG.md * ci: cache node_modules * refactor(client): refactor dialog functions to improve type inference * lint: warn non-null-assertion to reduce unexpected behaviour * limit depth of reply posts (misskey-dev#7979) * limit depth of reply posts * some tweaks Co-authored-by: syuilo <[email protected]> * Update CHANGELOG.md * introduce lint for client Resolve misskey-dev#7998 * fix * improve ide support * lint: add missing semicolon * fix(client): fix plugin activate and uninstall (misskey-dev#7991) * fix(client): fix plugin activate and uninstall * Fix(client): fix package activates * implement dev command * Update CONTRIBUTING.md * feat(client): collapse sub note automatically * fix(client): better error handling of file upload * feat(client): keep line breaks of translated text to improve readability * Update .eslintrc.js * update linr * Update .eslintrc.js * New Crowdin updates (misskey-dev#7984) * New translations ja-JP.yml (Czech) * New translations ja-JP.yml (Chinese Simplified) * New translations ja-JP.yml (Japanese, Kansai) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (English) * New translations ja-JP.yml (Chinese Traditional) * New translations ja-JP.yml (Ukrainian) * New translations ja-JP.yml (Spanish) * New translations ja-JP.yml (Russian) * New translations ja-JP.yml (Polish) * New translations ja-JP.yml (Dutch) * New translations ja-JP.yml (Korean) * New translations ja-JP.yml (Italian) * New translations ja-JP.yml (German) * New translations ja-JP.yml (Arabic) * New translations ja-JP.yml (German) * New translations ja-JP.yml (English) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Chinese Simplified) * New translations ja-JP.yml (German) * New translations ja-JP.yml (English) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * 12.97.0 * Update package.json * update banner image * Update README.md * Update README.md * client: ノートにモデレーターバッジを表示するのを廃止 * move tools dir into src * fix(client): ログインにおいてパスワードが誤っている際のエラーメッセージが正しく表示されない問題を修正 * fix(client): リアクションツールチップ、Renoteツールチップのユーザーの並び順を修正 * Update README.md * Implemented a rotate MFM (misskey-dev#8016) Co-authored-by: Richard Bowey <[email protected]> * Update ja-JP.yml * fix: toolsが動かないのを修正 (misskey-dev#8008) * Move tools * Fix DB * fix: notification.vueのIntersectionObserverまわりを修正 (misskey-dev#8010) * fix notification.vue * remove a blank line * disconnect intersection observer * disconnect2 * Update packages/client/src/components/notification.vue Co-authored-by: Acid Chicken (硫酸鶏) <[email protected]> * disconnect * oops Co-authored-by: Acid Chicken (硫酸鶏) <[email protected]> * fix(client): モバイルでタップしたときにツールチップが表示される問題を修正 * Fix install docs link in readme (misskey-dev#8017) * /antennas/notes API で日付による絞り込みができるようにする (misskey-dev#8015) * client: refine ui * Update CHANGELOG.md * feat(client): show confirm dialog when vote * feat(client): Renoteなノート詳細ページから元のノートページに遷移できるように * fix: LTLやGTLが無効になっている場合でもUI上にタブが表示される問題を修正 (misskey-dev#8026) * wip * add changelog * 変換ミス修正 * 🎨 * client: tweak ui * enhance(client): make possible to close image dialog with click Related misskey-dev#8023 * fix mentions in replies (misskey-dev#8030) * Update CHANGELOG.md * client: tweak ui * add todo * feat: Undo Accept (misskey-dev#7980) * allow breaking of follow * send undo * delete by using reject follow * fix: 画像ファイルの縦横サイズの取得で Exif Orientation を考慮する (misskey-dev#8014) * 画像ファイルの縦横サイズの取得で Exif Orientation を考慮する * test: Add rotate.jpg test * Webpublic 画像を返す時のみ Exif Orientation を考慮して縦横サイズを返す * test: Support orientation * refactoring https: //github.com/misskey-dev/pull/7901 Co-Authored-By: MeiMei <[email protected]> * client: tweak ui * Update CHANGELOG.md * client: tweak ui * client: tweak ui * client: tweak ui * New Crowdin updates (misskey-dev#8007) * New translations ja-JP.yml (English) * New translations ja-JP.yml (German) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Chinese Simplified) * New translations ja-JP.yml (Arabic) * New translations ja-JP.yml (Arabic) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (French) * New translations ja-JP.yml (Chinese Simplified) * New translations ja-JP.yml (Japanese, Kansai) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Indonesian) * New translations ja-JP.yml (English) * New translations ja-JP.yml (Chinese Traditional) * New translations ja-JP.yml (Ukrainian) * New translations ja-JP.yml (Spanish) * New translations ja-JP.yml (Russian) * New translations ja-JP.yml (Polish) * New translations ja-JP.yml (Korean) * New translations ja-JP.yml (Italian) * New translations ja-JP.yml (German) * New translations ja-JP.yml (Arabic) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Chinese Simplified) * New translations ja-JP.yml (Spanish) * New translations ja-JP.yml (German) * New translations ja-JP.yml (English) * New translations ja-JP.yml (Portuguese) * New translations ja-JP.yml (Portuguese) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (German) * New translations ja-JP.yml (English) * New translations ja-JP.yml (Chinese Simplified) * New translations ja-JP.yml (Arabic) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Dutch) * New translations ja-JP.yml (Dutch) * New translations ja-JP.yml (Dutch) * New translations ja-JP.yml (Dutch) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Indonesian) * Bump cypress from 9.0.0 to 9.1.0 (misskey-dev#8022) Bumps [cypress](https://github.com/cypress-io/cypress) from 9.0.0 to 9.1.0. - [Release notes](https://github.com/cypress-io/cypress/releases) - [Changelog](https://github.com/cypress-io/cypress/blob/develop/.releaserc.base.js) - [Commits](cypress-io/cypress@v9.0.0...v9.1.0) --- updated-dependencies: - dependency-name: cypress dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * client: tweak ui * fix(server): Fix misskey-dev#8032 * refactor(client): refactor ui components * enhance(client): improve usability * enhance(client): improve usability * New Crowdin updates (misskey-dev#8031) * New translations ja-JP.yml (German) * New translations ja-JP.yml (Chinese Simplified) * 12.98.0 * fix(client): pagesで関数を定義できない問題を修正 * fix(client): tweak style * fix(client): fix range slider rendering * Fix(client): APIコンソールで with credential がオフだとiが付与されないように (misskey-dev#8038) * Update other.vue (misskey-dev#8040) * fix(client): タッチ機能付きディスプレイを使っていてマウス操作をしている場合に一部機能が動作しない問題を修正 * add note * refactor(client): ✨ * fix(client): better hover detection * Fix(client): iをパラメーターに含めてもデフォルトのiが付与されるのを修正 (misskey-dev#8039) * Update about-misskey.vue * update deps * feat: user-level instance mute (misskey-dev#7712) * Update ja-JP.yml * Added settable config for muted instances * added psql query for removal of muted notes * Added filtering and trimming for instance mutes * cleaned up filtering of bad instance mutes and added a refresh at the end for the list on the client * Added notification & streaming timeline muting * Updated changelog * Added missing semicolon * Apply japanese string suggestions from robflop Co-authored-by: Robin B. <[email protected]> * Changed Ja-JP instance mute title string to one suggested by sousuke Co-authored-by: sousuke0422 <[email protected]> * Update ja-JP instanceMuteDescription based on sousuke's suggestion Co-authored-by: sousuke0422 <[email protected]> * added notification mute * added notification and note children muting * Fixed a bug where local notifications were getting filtered on cold start * Fixed instance mute imports * Fixed not saving/loading instance mutes * removed en-US translations for instance mute * moved instance mute migration to js * changed settings index back to spaces * removed destructuring assignment from notification stream in instance mute check call Co-authored-by: tamaina <[email protected]> * added .note accessor for checking note data instead of notification data * changed note to use Packed<'Note'> instead of any and removed usage of snake case Co-authored-by: tamaina <[email protected]> * changed notification mute check to check specifically for notification host * changed to using single quotes * moved @click to the end for the linter * revert unnecessary changes * restored newlines * whitespace removal Co-authored-by: syuilo <[email protected]> Co-authored-by: Robin B. <[email protected]> Co-authored-by: sousuke0422 <[email protected]> Co-authored-by: puffaboo <[email protected]> Co-authored-by: tamaina <[email protected]> * Update CHANGELOG.md * Update instance-mute.vue * Update instance-mute.vue * fix lint * Update .eslintrc.js * refactor(client): ✨ * feat: improve follow export * Fix japanese instanceMuteDescription string (misskey-dev#8047) * client: tweak style * client: tweak style * fix: integration links (misskey-dev#8036) * tweak style * 🎨 * fix(client): クリップの設定を編集できない問題を修正 Fix misskey-dev#8046 * fix(client): メニューなどがウィンドウの裏に隠れる問題を修正 * feat: カスタム絵文字エクスポート * Update CONTRIBUTING.md * tweak component * fix(client): fix z-index bug * clean up * refactor * Update export-custom-emojis.ts * New Crowdin updates (misskey-dev#8033) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Russian) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Chinese Simplified) * New translations ja-JP.yml (German) * New translations ja-JP.yml (English) * New translations ja-JP.yml (German) * New translations ja-JP.yml (English) * New translations ja-JP.yml (German) * New translations ja-JP.yml (Dutch) * New translations ja-JP.yml (Dutch) * New translations ja-JP.yml (Dutch) * New translations ja-JP.yml (Dutch) * New translations ja-JP.yml (Dutch) * New translations ja-JP.yml (Dutch) * New translations ja-JP.yml (French) * New translations ja-JP.yml (Chinese Simplified) * New translations ja-JP.yml (Japanese, Kansai) * New translations ja-JP.yml (Indonesian) * New translations ja-JP.yml (English) * New translations ja-JP.yml (Chinese Traditional) * New translations ja-JP.yml (Ukrainian) * New translations ja-JP.yml (Spanish) * New translations ja-JP.yml (Russian) * New translations ja-JP.yml (Polish) * New translations ja-JP.yml (Korean) * New translations ja-JP.yml (Italian) * New translations ja-JP.yml (German) * New translations ja-JP.yml (Arabic) * New translations ja-JP.yml (Dutch) * New translations ja-JP.yml (English) * New translations ja-JP.yml (Chinese Simplified) * enhance(backend): improve chart engine * Update CHANGELOG.md * New Crowdin updates (misskey-dev#8053) * New translations ja-JP.yml (Korean) * New translations ja-JP.yml (Korean) * New translations ja-JP.yml (Korean) * New translations ja-JP.yml (Korean) * New translations ja-JP.yml (Korean) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * enhance(client): make possible to leave a group * Update formula-core.vue * Update CHANGELOG.md * 12.99.0 * fix: YAMLファイルへのバックスペース文字混入対策 * 12.99.1 * Update 1639325650583-chart-v3.js * 12.99.2 * fix(client): オートコンプリートがダイアログの裏に隠れる問題を修正 * 12.99.3 * fix(client): 一部のコンポーネントが裏に隠れるのを修正 * fix(client): fix zindex issues Fix misskey-dev#8060 * chore: remove ms-vscode.typescript-javascript-grammar (misskey-dev#8061) * enhance(client): improve modal menu for mobile * 🎨 * update deps * enhance(client): リアクションピッカーの表示方法を選択できるように * 🎨 * 12.100.0 * fix(client): fix zindex issue * improve(client): tweak drawer max height * fix(client): tweak style * fix(client): fix zindex issue * 12.100.1 * fix(client): fix zindex issue Fix misskey-dev#8064 Fix misskey-dev#8063 * fix(client): fix zindex issue * feat(client): improve toast component and show welcome message * improve(client): show reload tip * refactor(client): improve $i type * 🎨 * fix(client/deck): カラムの増減がページをリロードするまで正しく反映されない問題を修正 Fix misskey-dev#8065 * Update CHANGELOG.md * 🎨 * clean up * fix(client): カスタム絵文字一覧ページの負荷が高いのを修正 * New Crowdin updates (misskey-dev#8058) * New translations ja-JP.yml (Chinese Simplified) * New translations ja-JP.yml (German) * New translations ja-JP.yml (English) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (French) * New translations ja-JP.yml (Chinese Simplified) * New translations ja-JP.yml (Japanese, Kansai) * New translations ja-JP.yml (Esperanto) * New translations ja-JP.yml (Indonesian) * New translations ja-JP.yml (English) * New translations ja-JP.yml (Chinese Traditional) * New translations ja-JP.yml (Ukrainian) * New translations ja-JP.yml (Spanish) * New translations ja-JP.yml (Russian) * New translations ja-JP.yml (Polish) * New translations ja-JP.yml (Dutch) * New translations ja-JP.yml (Korean) * New translations ja-JP.yml (Italian) * New translations ja-JP.yml (German) * New translations ja-JP.yml (Czech) * New translations ja-JP.yml (Arabic) * New translations ja-JP.yml (German) * New translations ja-JP.yml (English) * New translations ja-JP.yml (German) * New translations ja-JP.yml (English) * New translations ja-JP.yml (Chinese Simplified) * New translations ja-JP.yml (Japanese, Kansai) * New translations ja-JP.yml (Japanese, Kansai) * New translations ja-JP.yml (Russian) * New translations ja-JP.yml (German) * New translations ja-JP.yml (English) * 12.100.2 * run lint and test on qa * remove docker develop run until we have misskey store equivalent * fix cypress merge junk Co-authored-by: syuilo <[email protected]> Co-authored-by: tamaina <[email protected]> Co-authored-by: シアノン <[email protected]> Co-authored-by: MeiMei <[email protected]> Co-authored-by: Johann150 <[email protected]> Co-authored-by: okpierre <[email protected]> Co-authored-by: marihachi <[email protected]> Co-authored-by: シアノン <[email protected]> Co-authored-by: Robin B <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: nullobsi <[email protected]> Co-authored-by: futchitwo <[email protected]> Co-authored-by: Richard "EpicKitty" Bowey <[email protected]> Co-authored-by: Richard Bowey <[email protected]> Co-authored-by: Acid Chicken (硫酸鶏) <[email protected]> Co-authored-by: Francis Dinh <[email protected]> Co-authored-by: romaboo <[email protected]> Co-authored-by: sousuke0422 <[email protected]> Co-authored-by: puffaboo <[email protected]> Co-authored-by: Outvi V <[email protected]>

Johann150 force-pushed the renoters branch 2 times, most recently from 1819b8c to 7e771ce Compare November 5, 2021 10:28

Johann150 marked this pull request as ready for review November 5, 2021 10:40

Johann150 added 6 commits November 11, 2021 18:55

refactor: deduplicate renote button into component

9e5482d

For now the renoters tooltip just uses the reaction viewer component with a fixed emoji symbol instead.

chore: remove unnecessary CSS

1019c7f

fix: forgot to rename variable

c381fd1

enhance: use own tooltip instead of reaction viewer

bee860f

clean up style

762724d

fix additional renoters number

97df8f4

Johann150 force-pushed the renoters branch from 273eb85 to 97df8f4 Compare November 11, 2021 17:58

syuilo self-requested a review November 12, 2021 12:14

syuilo reviewed Nov 12, 2021

View reviewed changes

rename file to better represent content

aeaeb8a

syuilo merged commit 0e3213f into misskey-dev:develop Nov 12, 2021

Johann150 deleted the renoters branch November 12, 2021 14:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

enhance: show renoters #7954

enhance: show renoters #7954

Johann150 commented Nov 4, 2021 •

edited

Loading

okpierre commented Nov 5, 2021

Johann150 commented Nov 5, 2021

Johann150 commented Nov 5, 2021

Johann150 commented Nov 5, 2021

Johann150 commented Nov 5, 2021

Johann150 commented Nov 11, 2021

syuilo left a comment

syuilo Nov 12, 2021

Johann150 Nov 12, 2021

syuilo Nov 12, 2021

Johann150 Nov 12, 2021

syuilo commented Nov 12, 2021

enhance: show renoters #7954

enhance: show renoters #7954

Conversation

Johann150 commented Nov 4, 2021 • edited Loading

What

Why

okpierre commented Nov 5, 2021

Johann150 commented Nov 5, 2021

Johann150 commented Nov 5, 2021

Johann150 commented Nov 5, 2021

Johann150 commented Nov 5, 2021

Johann150 commented Nov 11, 2021

syuilo left a comment

Choose a reason for hiding this comment

syuilo Nov 12, 2021

Choose a reason for hiding this comment

Johann150 Nov 12, 2021

Choose a reason for hiding this comment

syuilo Nov 12, 2021

Choose a reason for hiding this comment

Johann150 Nov 12, 2021

Choose a reason for hiding this comment

syuilo commented Nov 12, 2021

Johann150 commented Nov 4, 2021 •

edited

Loading