Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mahjong): 麻雀をプレイできない問題を修正 #14268

Merged
merged 6 commits into from
Jul 25, 2024

Conversation

takejohn
Copy link

What

mahjongブランチにおける未定義変数などを定義しました。

Why

mahjongブランチを試してみると、ビルドに失敗したり実行時エラーが発生したりしたので。

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.70%. Comparing base (3afdafe) to head (cbbe592).
Report is 347 commits behind head on mahjong.

Additional details and impacted files
@@             Coverage Diff              @@
##           mahjong   #14268       +/-   ##
============================================
- Coverage    66.07%   39.70%   -26.37%     
============================================
  Files          990     1535      +545     
  Lines       115388   190958    +75570     
  Branches      5701     2613     -3088     
============================================
- Hits         76246    75827      -419     
- Misses       37708   114582    +76874     
+ Partials      1434      549      -885     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo syuilo merged commit 6c9f6e8 into misskey-dev:mahjong Jul 25, 2024
16 of 20 checks passed
@syuilo
Copy link
Member

syuilo commented Jul 25, 2024

🙏🏿

@takejohn takejohn deleted the patch/mahjong_takejohn branch July 31, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants