Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): GTL上でのサーバー表示をインスタンスのロゴのみに切り替えできるように #14141

Closed
wants to merge 3 commits into from

Conversation

MattyaDaihuku
Copy link

@MattyaDaihuku MattyaDaihuku commented Jul 6, 2024

What

GTLやSTLでのリモートユーザーのインスタンスをロゴのみの表示に切り替え可能にしました。

  • 表示例

Screenshot 2024-07-06 20 34 28

 GTL上ではこのように表示される。
 従来の表示よりTLが見やすくなり、リモートユーザーとローカルユーザーをアイコンで
 見分けられる。

  • トグルの実装

Screenshot 2024-07-06 20 34 56

 従来の表示が望まれる場合を考慮し、切り替えできるように実装
 ノートのサーバー情報にて、表示しないを選択している場合はトグルを非表示に

Screenshot 2024-07-06 20 35 19

Why

 TLの見やすさ向上のため

Fix #13623

Additional info (optional)

 ローカル環境のみで動作を確認しているため、GTLでの挙動は未確認

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Jul 6, 2024
@MattyaDaihuku MattyaDaihuku changed the title feat: GTL上でのサーバー表示をインスタンスのロゴのみに切り替えできるように feat(frontend): GTL上でのサーバー表示をインスタンスのロゴのみに切り替えできるように Jul 6, 2024
Copy link

codecov bot commented Jul 6, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 9 lines in your changes missing coverage. Please review.

Project coverage is 20.24%. Comparing base (b9ed3b2) to head (dd21c8e).
Report is 2 commits behind head on develop.

Files Patch % Lines
packages/frontend/src/pages/settings/general.vue 0.00% 4 Missing ⚠️
packages/frontend/src/store.ts 0.00% 4 Missing ⚠️
...ackages/frontend/src/components/MkInstanceIcon.vue 98.21% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #14141      +/-   ##
===========================================
- Coverage    20.30%   20.24%   -0.06%     
===========================================
  Files          698      699       +1     
  Lines        97636    97732      +96     
  Branches      1013     1014       +1     
===========================================
- Hits         19825    19788      -37     
- Misses       77292    77424     +132     
- Partials       519      520       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

リモートユーザーの所属サーバーをアイコンで表示する方式
1 participant