Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docker-compose): 推奨の名前にする #14096

Merged
merged 4 commits into from
Jun 28, 2024

Conversation

nullnyat
Copy link
Contributor

What

docker-compose.ymlから非推奨の項目を削除し、 ファイル名を推奨のcompose.yamlへ変更。

Why

docker-compose.ymlは非推奨なので。
https://github.com/compose-spec/compose-spec/blob/5c18e329d5a15a15e4b636ed093b256b96615e33/spec.md#compose-file

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added packages/backend Server side specific issue/PR packages/backend:test labels Jun 26, 2024
Copy link
Contributor

github-actions bot commented Jun 26, 2024

このPRによるapi.jsonの差分

差分はこちら

Get diff files from Workflow Page

Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.27%. Comparing base (1c5d0cf) to head (3d87f41).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #14096       +/-   ##
============================================
- Coverage    77.90%   65.27%   -12.63%     
============================================
  Files          185     1004      +819     
  Lines        25562   115257    +89695     
  Branches       487     5493     +5006     
============================================
+ Hits         19915    75239    +55324     
- Misses        5640    38579    +32939     
- Partials         7     1439     +1432     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kakkokari-gtyih
Copy link
Contributor

yamlファイルの拡張子は基本的に*.ymlばっかりにしてた気がするのでそのほうがいいかも

@nullnyat
Copy link
Contributor Author

yamlからymlに変更しました🙏

@syuilo syuilo merged commit a6edd50 into misskey-dev:develop Jun 28, 2024
26 checks passed
@syuilo
Copy link
Member

syuilo commented Jun 28, 2024

🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend:test packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants