Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(frontend): Replace with vue/no-setup-props-reactivity-loss rule #14062

Merged
merged 1 commit into from
Jun 22, 2024

Conversation

woxtu
Copy link
Contributor

@woxtu woxtu commented Jun 21, 2024

What

ESLintのvue/no-setup-props-destructureルールがvue/no-setup-props-reactivity-lossにリネームされていたので変更します。
https://eslint.vuejs.org/rules/no-setup-props-destructure.html

Why

元のルールが非推奨になっているので。

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Jun 21, 2024
Copy link

codecov bot commented Jun 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.68%. Comparing base (a9012d3) to head (7170b2d).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #14062      +/-   ##
===========================================
- Coverage    77.79%   77.68%   -0.12%     
===========================================
  Files          184      183       -1     
  Lines        25536    25410     -126     
  Branches       487      487              
===========================================
- Hits         19865    19739     -126     
  Misses        5664     5664              
  Partials         7        7              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Sponsor Member

@KisaragiEffective KisaragiEffective left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@syuilo syuilo merged commit 4d2edde into misskey-dev:develop Jun 22, 2024
17 checks passed
@syuilo
Copy link
Member

syuilo commented Jun 22, 2024

🙏🏻

@woxtu woxtu deleted the no-setup-props-reactivity-loss branch June 22, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants