-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor&fix: RateLimiterService #13997
base: develop
Are you sure you want to change the base?
Conversation
このPRによるapi.jsonの差分 差分はこちら |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #13997 +/- ##
===========================================
+ Coverage 65.28% 65.29% +0.01%
===========================================
Files 1004 1004
Lines 115245 115228 -17
Branches 4617 5541 +924
===========================================
+ Hits 75233 75241 +8
+ Misses 39985 39960 -25
Partials 27 27 ☔ View full report in Codecov by Sentry. |
ちょっとoutofscopeかもしれないけどrefactorついでにpolicyでrateLimitFactorを調整すると |
正確には2乗に比例するはずです。 |
mark this pull request as "ready for review": #13994 is merged |
実装しました |
This comment was marked as resolved.
This comment was marked as resolved.
IDEのeslintがコンフィグのロードに失敗してましたすみません |
あ、セマンティックコミットじゃない 🙇🏻 |
What
#13994 (comment)
を実装しました
Why
What参照
Additional info (optional)
diffとしては大きいですが、小さな作業単位にcommitを分けたので、レビューするときはコミット単位にみてもらうとおそらく見やすいと思います。
#13994を先にマージする必要があるため、マージされるまでDraftにしますが Ready for Review です
Checklist