Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): ベースロールを編集してもUI上では変更が反映されない問題を修正 #13995

Merged
merged 3 commits into from
Jun 22, 2024

Conversation

kakkokari-gtyih
Copy link
Contributor

@kakkokari-gtyih kakkokari-gtyih commented Jun 14, 2024

What

書いてある通り
ロールが変更されてもUI上ではキャッシュが効いていて変更が反映されないので

Why

Fix #13796

Additional info (optional)

他の利用者側はどうやねんという問題はあるがそれは別途議論

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Jun 14, 2024
@kakkokari-gtyih kakkokari-gtyih changed the title fix(frontend): ベースロールを変更してもUI上では変更が反映されない問題を修正 fix(frontend): ベースロールを編集してもUI上では変更が反映されない問題を修正 Jun 14, 2024
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.84%. Comparing base (b50eb51) to head (8b3bc01).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #13995       +/-   ##
============================================
+ Coverage    66.59%   77.84%   +11.25%     
============================================
  Files         1007      185      -822     
  Lines       119991    25601    -94390     
  Branches      5598      487     -5111     
============================================
- Hits         79903    19930    -59973     
+ Misses       38649     5664    -32985     
+ Partials      1439        7     -1432     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kakkokari-gtyih
Copy link
Contributor Author

👀

@Sayamame-beans
Copy link
Member

Sayamame-beans commented Jun 15, 2024

probably fix #13796 ?

Copy link
Member

@anatawa12 anatawa12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

とりあえず本人に対する対処としては良さそう

@kakkokari-gtyih
Copy link
Contributor Author

コンフリクト解消

@syuilo syuilo merged commit bf403aa into misskey-dev:develop Jun 22, 2024
17 checks passed
@syuilo
Copy link
Member

syuilo commented Jun 22, 2024

🙏🏻

@kakkokari-gtyih kakkokari-gtyih deleted the fix-role-edit-0 branch June 22, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
4 participants