Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

アンテナ、リスト等の名前をdeckのカラム名のデフォルト値にするように #13992

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

anatawa12
Copy link
Member

What

Fixes #11077

Why

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@anatawa12 anatawa12 changed the title アンテナ、リスト等の名前をカラム名のデフォルト値にするように アンテナ、リスト等の名前をdeckのカラム名のデフォルト値にするように Jun 14, 2024
@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Jun 14, 2024
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

Attention: Patch coverage is 20.54795% with 58 lines in your changes missing coverage. Please review.

Project coverage is 20.46%. Comparing base (8b4933c) to head (cda207f).

Files Patch % Lines
packages/frontend/src/ui/deck/channel-column.vue 0.00% 11 Missing ⚠️
packages/frontend/src/ui/deck/list-column.vue 0.00% 11 Missing ⚠️
packages/frontend/src/ui/deck/deck-store.ts 0.00% 9 Missing ⚠️
packages/frontend/src/ui/deck/antenna-column.vue 0.00% 7 Missing ⚠️
packages/frontend/src/ui/deck.vue 0.00% 5 Missing ⚠️
...ages/frontend/src/ui/deck/role-timeline-column.vue 0.00% 5 Missing ⚠️
packages/frontend/src/ui/deck/column.vue 0.00% 3 Missing ⚠️
packages/frontend/src/ui/deck/direct-column.vue 0.00% 2 Missing ⚠️
packages/frontend/src/ui/deck/mentions-column.vue 0.00% 2 Missing ⚠️
...ages/frontend/src/ui/deck/notifications-column.vue 0.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #13992       +/-   ##
============================================
- Coverage    40.16%   20.46%   -19.71%     
============================================
  Files         1521      701      -820     
  Lines       188552    98700    -89852     
  Branches      3509     1025     -2484     
============================================
- Hits         75735    20200    -55535     
+ Misses      112246    77979    -34267     
+ Partials       571      521       -50     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kakkokari-gtyih
Copy link
Contributor

lintがあかんかも

@anatawa12
Copy link
Member Author

dockleに気を取られて気づいてなかったですありがとうございます

@anatawa12
Copy link
Member Author

直しました(fix on saveが切れてた)

@Sayamame-beans
Copy link
Collaborator

Conflict解消

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deckのカラム追加時にアンテナ、リスト等の名前をカラムの名前にしてほしい
4 participants